fix(web-ui): sync Mermaid Monaco editor with app theme#335
Merged
bobleer merged 1 commit intoGCWing:mainfrom Apr 2, 2026
Merged
fix(web-ui): sync Mermaid Monaco editor with app theme#335bobleer merged 1 commit intoGCWing:mainfrom
bobleer merged 1 commit intoGCWing:mainfrom
Conversation
- Extract bitfun-light Monaco theme and register in beforeMount - Add MonacoThemeSync.registerThemesForEditorInstance and getTargetMonacoThemeId - MermaidSyntaxHighlighter follows app theme and updates on theme change
bobleer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Mermaid syntax highlighter Monaco editor was hardcoded to
bitfun-dark, which looked inconsistent in light theme.Changes
getBitfunLightMonacoTheme; addgetTargetMonacoThemeIdandregisterThemesForEditorInstanceso themes are registered inbeforeMountand the editor does not briefly fall back to the default light theme.useThemeandthemeService; register themes inbeforeMount; update the mounted editor theme when the app theme changes.Verification
eslintandtsc --noEmit(web-ui) passed locally.