refactor: finalize streamed tool calls on boundaries#330
Merged
GCWing merged 1 commit intoGCWing:mainfrom Apr 2, 2026
Merged
Conversation
- replace brace-closure based tool-call completion with boundary-driven accumulation - add shared pending tool accumulator for streaming and non-stream aggregation - finalize tool arguments on new tool, finish reason, stream end, and shutdown - keep invalid streamed tool calls marked as errors for downstream execution handling - preserve legacy `send_message()` behavior by dropping invalid finalized tool calls - update stale stream processor comments and tighten invalid tool error messages - add regression tests for mixed tool/usage chunks and same-chunk finish finalization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send_message()behavior by dropping invalid finalized tool calls