fix(web-ui): restore startup and enforce checks

.github/workflows/ci.yml

@@ -108,6 +108,9 @@ jobs:
       - name: Type-check web UI
         run: pnpm run type-check:web
 
+      - name: Lint web UI
+        run: pnpm run lint:web
+
       - name: Build web UI
         run: pnpm run build:web
 

src/web-ui/eslint.config.mjs

@@ -1,3 +1,4 @@
+import js from '@eslint/js';
 import globals from 'globals';
 import tseslint from 'typescript-eslint';
 import reactHooks from 'eslint-plugin-react-hooks';
@@ -10,12 +11,24 @@ export default tseslint.config(
       'coverage/**',
       'node_modules/**',
       'public/monaco-editor/**',
+      'src/**/*.test.ts',
+      'src/**/*.test.tsx',
+      'src/**/*.spec.ts',
+      'src/**/*.spec.tsx',
+      'src/**/*.example.tsx',
       'src/component-library/components/registry.tsx',
+      'src/component-library/preview/**',
       'src/shared/context-system/core/types/**',
+      'src/shared/context-menu-system/examples/**',
+      'src/tools/mermaid-editor/examples/**',
     ],
   },
   {
     files: ['src/**/*.{ts,tsx}'],
+    extends: [js.configs.recommended, ...tseslint.configs.recommended],
+    linterOptions: {
+      reportUnusedDisableDirectives: 'warn',
+    },
     languageOptions: {
       ecmaVersion: 2022,
       sourceType: 'module',
@@ -37,13 +50,46 @@ export default tseslint.config(
     },
     rules: {
       ...reactHooks.configs.recommended.rules,
+      'react-hooks/exhaustive-deps': 'error',
+      'no-undef': 'off',
+      'no-unused-vars': 'off',
+      'no-use-before-define': 'off',
+      'no-case-declarations': 'warn',
+      'no-cond-assign': 'warn',
+      'no-control-regex': 'warn',
+      'no-empty': ['warn', { allowEmptyCatch: true }],
+      'no-useless-escape': 'warn',
+      'prefer-const': 'warn',
       'react-refresh/only-export-components': ['warn', { allowConstantExport: true }],
+      '@typescript-eslint/no-empty-object-type': 'warn',
       '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/no-namespace': 'warn',
+      '@typescript-eslint/no-use-before-define': [
+        'error',
+        {
+          functions: false,
+          classes: true,
+          variables: true,
+          enums: true,
+          typedefs: true,
+          ignoreTypeReferences: true,
+        },
+      ],
+      '@typescript-eslint/no-unused-expressions': 'warn',
       '@typescript-eslint/no-unsafe-member-access': 'off',
+      '@typescript-eslint/no-unused-vars': [
+        'warn',
+        {
+          argsIgnorePattern: '^_',
+          varsIgnorePattern: '^_',
+          caughtErrorsIgnorePattern: '^_',
+        },
+      ],
     },
   },
   {
     files: ['*.{ts,mts,cts}', '*.config.{ts,mts,cts}', 'vite.config.ts'],
+    extends: [js.configs.recommended, ...tseslint.configs.recommended],
     languageOptions: {
       ecmaVersion: 2022,
       sourceType: 'module',

src/web-ui/src/app/App.tsx

@@ -1,6 +1,6 @@
 import { useEffect, useCallback, useState, useRef } from 'react';
 import { ChatProvider, useAIInitialization } from '../infrastructure';
-import { ViewModeProvider } from '../infrastructure/contexts/ViewModeContext';
+import { ViewModeProvider } from '../infrastructure/contexts/ViewModeProvider';
 import { SSHRemoteProvider } from '../features/ssh-remote';
 import AppLayout from './layout/AppLayout';
 import { useCurrentModelConfig } from '../hooks/useModelConfigs';

src/web-ui/src/app/components/NavPanel/MainNav.tsx

@@ -103,7 +103,11 @@ const MainNav: React.FC<MainNavProps> = ({
   const toggleSection = useCallback((id: string) => {
     setExpandedSections(prev => {
       const next = new Set(prev);
-      next.has(id) ? next.delete(id) : next.add(id);
+      if (next.has(id)) {
+        next.delete(id);
+      } else {
+        next.add(id);
+      }
       return next;
     });
   }, []);

src/web-ui/src/app/components/NavPanel/components/BranchQuickSwitch.tsx

@@ -73,12 +73,6 @@ export const BranchQuickSwitch: React.FC<BranchQuickSwitchProps> = ({
     }
   }, [isOpen, anchorRef]);
 
-  useEffect(() => {
-    if (isOpen && repositoryPath) {
-      loadBranches();
-    }
-  }, [isOpen, repositoryPath]);
-
   useEffect(() => {
     if (!isOpen) {
       setSearchTerm('');
@@ -113,7 +107,7 @@ export const BranchQuickSwitch: React.FC<BranchQuickSwitchProps> = ({
     return () => document.removeEventListener('keydown', handleKeyDown);
   }, [isOpen, onClose]);
 
-  const loadBranches = async () => {
+  const loadBranches = useCallback(async () => {
     setIsLoading(true);
     try {
       const cachedState = gitStateManager.getState(repositoryPath);
@@ -142,7 +136,13 @@ export const BranchQuickSwitch: React.FC<BranchQuickSwitchProps> = ({
     } finally {
       setIsLoading(false);
     }
-  };
+  }, [repositoryPath]);
+
+  useEffect(() => {
+    if (isOpen && repositoryPath) {
+      void loadBranches();
+    }
+  }, [isOpen, loadBranches, repositoryPath]);
 
   const filteredBranches = useMemo(() => {
     let result = branches;

src/web-ui/src/app/components/NavPanel/components/PersistentFooterActions.tsx

@@ -28,10 +28,12 @@ import NotificationButton from '../../TitleBar/NotificationButton';
 import { AboutDialog } from '../../AboutDialog';
 import { RemoteConnectDialog } from '../../RemoteConnectDialog';
 import {
-  getRemoteConnectDisclaimerAgreed,
-  setRemoteConnectDisclaimerAgreed,
   RemoteConnectDisclaimerContent,
 } from '../../RemoteConnectDialog/RemoteConnectDisclaimer';
+import {
+  getRemoteConnectDisclaimerAgreed,
+  setRemoteConnectDisclaimerAgreed,
+} from '../../RemoteConnectDialog/remoteConnectDisclaimerStorage';
 import { MERMAID_INTERACTIVE_EXAMPLE } from '@/flow_chat/constants/mermaidExamples';
 
 const PersistentFooterActions: React.FC = () => {

src/web-ui/src/app/components/NavPanel/sections/workspaces/WorkspaceItem.tsx

@@ -24,7 +24,7 @@ import {
   isRemoteWorkspace,
   type WorkspaceInfo,
 } from '@/shared/types';
-import { SSHContext } from '@/features/ssh-remote/SSHRemoteProvider';
+import { SSHContext } from '@/features/ssh-remote/SSHRemoteContext';
 
 interface WorkspaceItemProps {
   workspace: WorkspaceInfo;
@@ -213,7 +213,7 @@ const WorkspaceItem: React.FC<WorkspaceItemProps> = ({
     } finally {
       setIsResettingWorkspace(false);
     }
-  }, [isActive, isDefaultAssistantWorkspace, isResettingWorkspace, resetAssistantWorkspace, t, workspace.id, workspace.rootPath]);
+  }, [isActive, isDefaultAssistantWorkspace, isResettingWorkspace, resetAssistantWorkspace, t, workspace.id, workspace.rootPath, workspace.workspaceKind]);
 
   const handleReveal = useCallback(async () => {
     setMenuOpen(false);
@@ -274,10 +274,7 @@ const WorkspaceItem: React.FC<WorkspaceItemProps> = ({
   }, [
     setActiveWorkspace,
     t,
-    workspace.id,
-    workspace.rootPath,
-    workspace.workspaceKind,
-    workspace.connectionId,
+    workspace,
   ]);
 
   const handleCreateCodeSession = useCallback(() => {

src/web-ui/src/app/components/NavPanel/sections/workspaces/WorkspaceListSection.tsx

@@ -96,7 +96,6 @@ const WorkspaceListSection: React.FC<WorkspaceListSectionProps> = ({ variant })
       dropTargetRef.current = next;
       return next;
     });
-  // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []); // Intentionally empty: reads from refs, not closed-over state
 
   const handleDragLeave = useCallback((workspaceId: string) => (event: React.DragEvent<HTMLDivElement>) => {

src/web-ui/src/app/components/RemoteConnectDialog/RemoteConnectDialog.tsx

@@ -16,10 +16,12 @@ import {
   type RemoteConnectStatus,
 } from '@/infrastructure/api/service-api/RemoteConnectAPI';
 import {
-  getRemoteConnectDisclaimerAgreed,
-  setRemoteConnectDisclaimerAgreed,
   RemoteConnectDisclaimerContent,
 } from './RemoteConnectDisclaimer';
+import {
+  getRemoteConnectDisclaimerAgreed,
+  setRemoteConnectDisclaimerAgreed,
+} from './remoteConnectDisclaimerStorage';
 import './RemoteConnectDialog.scss';
 
 // ── Types ────────────────────────────────────────────────────────────

src/web-ui/src/app/components/RemoteConnectDialog/RemoteConnectDisclaimer.tsx

@@ -3,24 +3,6 @@ import { Badge } from '@/component-library';
 import { useI18n } from '@/infrastructure/i18n';
 import './RemoteConnectDisclaimer.scss';
 
-export const REMOTE_CONNECT_DISCLAIMER_KEY = 'bitfun:remote-connect:disclaimer-agreed:v1';
-
-export const getRemoteConnectDisclaimerAgreed = (): boolean => {
-  try {
-    return localStorage.getItem(REMOTE_CONNECT_DISCLAIMER_KEY) === 'true';
-  } catch {
-    return false;
-  }
-};
-
-export const setRemoteConnectDisclaimerAgreed = (): void => {
-  try {
-    localStorage.setItem(REMOTE_CONNECT_DISCLAIMER_KEY, 'true');
-  } catch {
-    // Ignore storage failures and fall back to in-memory state.
-  }
-};
-
 interface RemoteConnectDisclaimerContentProps {
   agreed: boolean;
   onClose: () => void;

src/web-ui/src/app/components/RemoteConnectDialog/remoteConnectDisclaimerStorage.ts

@@ -0,0 +1,17 @@
+export const REMOTE_CONNECT_DISCLAIMER_KEY = 'bitfun:remote-connect:disclaimer-agreed:v1';
+
+export const getRemoteConnectDisclaimerAgreed = (): boolean => {
+  try {
+    return localStorage.getItem(REMOTE_CONNECT_DISCLAIMER_KEY) === 'true';
+  } catch {
+    return false;
+  }
+};
+
+export const setRemoteConnectDisclaimerAgreed = (): void => {
+  try {
+    localStorage.setItem(REMOTE_CONNECT_DISCLAIMER_KEY, 'true');
+  } catch {
+    // Ignore storage failures and fall back to in-memory state.
+  }
+};

src/web-ui/src/app/components/TitleBar/TitleBar.tsx

@@ -135,7 +135,7 @@ const TitleBar: React.FC<TitleBarProps> = ({
     } catch (error) {
       log.error('Failed to open workspace', error);
     }
-  }, [openWorkspace]);
+  }, [openWorkspace, t]);
 
   const handleNewProject = useCallback(() => {
     setShowNewProjectDialog(true);

src/web-ui/src/app/components/panels/BranchSelectModal.tsx

@@ -61,12 +61,6 @@ export const BranchSelectModal: React.FC<BranchSelectModalProps> = ({
   const resolvedTitle = title ?? t('branchSelect.title');
 
 
-  useEffect(() => {
-    if (isOpen && repositoryPath) {
-      loadBranches();
-    }
-  }, [isOpen, repositoryPath]);
-
   useEffect(() => {
     if (!isOpen) {
       setSearchTerm('');
@@ -91,7 +85,7 @@ export const BranchSelectModal: React.FC<BranchSelectModalProps> = ({
     return () => document.removeEventListener('keydown', handleEscape);
   }, [isOpen, onClose]);
 
-  const loadBranches = async () => {
+  const loadBranches = useCallback(async () => {
     setIsLoading(true);
     setError(null);
     try {
@@ -103,7 +97,13 @@ export const BranchSelectModal: React.FC<BranchSelectModalProps> = ({
     } finally {
       setIsLoading(false);
     }
-  };
+  }, [repositoryPath, t]);
+
+  useEffect(() => {
+    if (isOpen && repositoryPath) {
+      void loadBranches();
+    }
+  }, [isOpen, loadBranches, repositoryPath]);
 
   const filteredBranches = useMemo<SelectableBranch[]>(() => {
     let result = branches;

src/web-ui/src/app/components/panels/FilesPanel.tsx

@@ -155,7 +155,7 @@ const FilesPanel: React.FC<FilesPanelProps> = ({
       }
     }
     prevWorkspacePathRef.current = workspacePath;
-  }, [workspacePath, clearSearch]);
+  }, [workspacePath, clearSearch, onViewModeChange]);
 
   // ===== File Operation Handlers =====
 
@@ -866,6 +866,7 @@ const FilesPanel: React.FC<FilesPanelProps> = ({
         confirmText={inputDialog.type === 'newFile' ? t('dialog.newFile.confirm') : t('dialog.newFolder.confirm')}
         cancelText={inputDialog.type === 'newFile' ? t('dialog.newFile.cancel') : t('dialog.newFolder.cancel')}
         validator={(value) => {
+          // eslint-disable-next-line no-control-regex -- Windows filename rules explicitly forbid ASCII control characters.
           if (!/^[^<>:"/\\|?*\x00-\x1F]+$/.test(value)) {
             return t('validation.invalidFilename');
           }