-
Notifications
You must be signed in to change notification settings - Fork 4
CDN Alert Feature #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CostaGCore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
|
|
||
| async testDatasource(): Promise<any> { | ||
| try { | ||
| // TODO: Use the fetch function instead datasourceRequest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you committing this TODO? Where you supposed to convert it to use fetch?
| ); | ||
| } | ||
|
|
||
| // TODO: Use the fetch function instead datasourceRequest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you committing this TODO? Where you supposed to convert it to use fetch?
| version "10.5.0" | ||
| resolved "https://registry.yarnpkg.com/glob/-/glob-10.5.0.tgz#8ec0355919cd3338c28428a23d4f24ecc5fe738c" | ||
| integrity sha512-DfXN8DfhJ7NH3Oe7cFmu3NCu1wKbkReJ8TorzSAFbSKrlNaQSKfIzqYqVY8zlbs2NLBbWpRiU52GX2PbaBVNkg== | ||
| glob@^10.2.7: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The glob 10.2.7 is marked by Dependabot alerts "Command injection via -c/--cmd executes matches with shell:true"
https://github.com/G-Core/cdn-stats-datasource-plugin/security/dependabot/103
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FearLeSS-21 @CostaGCore, please take a look
No description provided.