Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings #14

Merged
merged 23 commits into from
Jul 8, 2022
Merged

Settings #14

merged 23 commits into from
Jul 8, 2022

Conversation

not-nef
Copy link
Member

@not-nef not-nef commented Jul 3, 2022

I am inviting everyone to work with me on this.

@not-nef not-nef marked this pull request as draft July 3, 2022 11:02
@not-nef not-nef linked an issue Jul 3, 2022 that may be closed by this pull request
@sumeshir26
Copy link
Member

Nice :) Reviewing soon

@sumeshir26 sumeshir26 self-requested a review July 3, 2022 13:00
Copy link
Member

@sumeshir26 sumeshir26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this is not working:
image
It seems to not detect things in its own dir

@sumeshir26
Copy link
Member

Well once i cd to the src dir it works... odd...

BTW the UI looks nice!

@sumeshir26 sumeshir26 self-requested a review July 3, 2022 13:04
@not-nef
Copy link
Member Author

not-nef commented Jul 3, 2022

@sumeshir26 i forgot that

@not-nef
Copy link
Member Author

not-nef commented Jul 3, 2022

and thanks a lot btw!

@sumeshir26
Copy link
Member

Np, I think the ui would look better if you remove the border around the frames, did u try that?

@not-nef
Copy link
Member Author

not-nef commented Jul 3, 2022

i made the borders so you could differentiate between sidebar and settings page. feel free to change it but please dont completely remove it or find a way to make them differentiable

@sumeshir26
Copy link
Member

Ok. do it how u feel is good

@sumeshir26
Copy link
Member

@not-nef I added a font loading method which does not rely on matplotlib but on Tkinter only, and it dosent take forever to build the font cache

@not-nef
Copy link
Member Author

not-nef commented Jul 4, 2022

Just wanted to ask you: what do you use to commit to github? I have always done it through the gh website. I assume you use git. But i dont know how to use it. Could you maybe take some time to explain to me how to use it to commit to a gh repo? I would really appreciate it!

@im-coder-lg
Copy link
Member

Hi guys, it's me. I am not officially back since my exams are coming(the first exams of the year), and I couldn't respond much since I had problems of my own, but hey, I am back to help whenever I can.
Git is version control, ie. it allows you to save revisions of a file through commits - a secure method to save a snapshot of your edits. Each commit is secured by its SHA256 hash, which we call a commit tag/commit hash/etc.

Git, in its entirety, is quite simple. Sure, you have to set user config, but I have an ace up my sleeve for that.

So, let's make a simple guide.

Add/Stage files

Whenever you commit, you have to select the files you want to commit, ie. if you updated docs and are testing a file edit, you make sure that doesn't get staged(ready for committing) so that you can test peacefully without the pains of accusations(they do lead back to you). Git is a CLI, so we need to use commands. These are universal, so no changes will take place.

$ # To stage particular file(s)
$ git add filename.ext filename2.ext # and so on
filename => file name
ext=> file extension

Commit

So, this is a bit easy. Committing is just taking a snapshot locally. We all know how to do it, so I'll just shoot.

# Commit
$ git commit -m "Title message: following semantic commits is better" -m "Description"
# You can sign them(flag: -S), but that is of no use; any way you will learn it and possibly regret it too - failed for me :/

Push

This is fairly easy. This depends upon your file changes, so it is relative to the bits changed.

git push

My ace.

GitHub CLI. It is a smart thing since it is an extension of Git. Once you install and type gh auth login, it asks for authenticating your Git credentials, so it's easy to set Git configuration. It's available for Windows, Mac and Linux, at cli.github.com.

Once you log in, you can clone repos like so:

gh repo clone [user-name]/[repo-name]

Please amend the user-name and repo-name values w/ your own WITHOUT the square brackets.

@im-coder-lg
Copy link
Member

PS: Commit hashes are so random, it is SO rare to get the same hash; plus it's useless since that is a conflict.
PPS: You can use them to link back to commits here.

@im-coder-lg
Copy link
Member

PPPS: It doesn't work on Linux :/

@im-coder-lg
Copy link
Member

Just wanted to ask you: what do you use to commit to github? I have always done it through the gh website. I assume you use git. But i dont know how to use it. Could you maybe take some time to explain to me how to use it to commit to a gh repo? I would really appreciate it!

I think @sumeshir26 uses the VS Code's Source Control panel; I am classic via CLI, it gives me lot of control.

Perhaps I'll make a blog on this, when the time is right. I hope the main part helps. Use GitHub CLI to clone; it is efficient.

@sumeshir26
Copy link
Member

@not-nef I mostly use VsCode's github intigration. Just click t icon on t sidebar

@not-nef
Copy link
Member Author

not-nef commented Jul 4, 2022

Thanks!!

@not-nef
Copy link
Member Author

not-nef commented Jul 4, 2022

First commit with git! finally

@not-nef
Copy link
Member Author

not-nef commented Jul 4, 2022

programming is hard

@not-nef
Copy link
Member Author

not-nef commented Jul 5, 2022

Courier New turned out to not be the default font

@not-nef
Copy link
Member Author

not-nef commented Jul 5, 2022

Gonna add font size, mica and hotkey setting tomorrow!

@sumeshir26
Copy link
Member

@not-nef I added the font size option, do you think it is good?

(Also, you should reallay get rid of txt2.py since it causes many problems like not cfgtools.init() not working when running it

@not-nef
Copy link
Member Author

not-nef commented Jul 6, 2022

i was about to do commit that ._.

@not-nef
Copy link
Member Author

not-nef commented Jul 6, 2022

btw your method of getting a list for the fonts does not have all fonts it seems

@not-nef
Copy link
Member Author

not-nef commented Jul 6, 2022

also i have implemented it a little different

@not-nef
Copy link
Member Author

not-nef commented Jul 6, 2022

this is a huge pr

@sumeshir26
Copy link
Member

sumeshir26 commented Jul 6, 2022

btw your method of getting a list for the fonts does not have all fonts it seems

What fonts are not seen by you?

@not-nef
Copy link
Member Author

not-nef commented Jul 6, 2022

Helvetica eg

@sumeshir26
Copy link
Member

Helvetica eg

Hmm I see Helvetica ...

@not-nef
Copy link
Member Author

not-nef commented Jul 6, 2022

do you see it in the dropdown?

@not-nef not-nef linked an issue Jul 7, 2022 that may be closed by this pull request
Closed
@not-nef
Copy link
Member Author

not-nef commented Jul 7, 2022

I think we are ready!

@not-nef not-nef marked this pull request as ready for review July 7, 2022 16:31
@not-nef not-nef requested a review from sumeshir26 July 7, 2022 16:31
@HuyHung1408
Copy link

I think I've missed lots of things here 🥲, just checked it out, looks great tbh

@not-nef
Copy link
Member Author

not-nef commented Jul 8, 2022

Thanks! :D

@not-nef not-nef dismissed sumeshir26’s stale review July 8, 2022 15:03

Not needed ;)

@not-nef not-nef merged commit 0984a0b into main Jul 8, 2022
@not-nef not-nef deleted the settings branch July 8, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings Mica
4 participants