Add support for downloading related tokens #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riteria if card for given language was not found
Furrman
added
documentation
Furrman
added a commit
that referenced
this pull request
May 7, 2024
* Add support for downloading related tokens (#11) * Refactor CardListFileParser to get Foil Etched and ExpansionCode covered with tests * Load image urls for specific version of card * Correct VSCode debug configuration * Cleaning the code * Add support for art cards * Correct README and * Minor issue in log inside MagicCardService * Fix code for loading cards from file * Fix issue with tag version on release pipeline * Add FilePaths.cs, LanguageCodes.cs, and ILanguageService.cs * Refactor ArchidektPrinter to use IArchidektPrinter interface * Fix issue with getting deck details twice for deck from internet option * Refactor ArchidektPrinter to include language code parameter in GenerateWord method * Refactor MagicCardService to use IMagicCardService interface * Refactor MagicCardService to update card image links with language code * Refactor NLog configuration to use consistent log level and file path * Refactor MagicCardService and repeat search for a card with default criteria if card for given language was not found * Update README * Refactor classes to use interfaces and use records for 3rd party API * Get the related tokens from each card * Add DTOs to keep related token information for a card * Correct README * Add tokens to card list of the deck for printing * Update tokenCopies parameter to be nullable in Program.cs * Update README.md (#12)
Furrman
added a commit
that referenced
this pull request
May 20, 2024
* Refactor CardListFileParser to get Foil Etched and ExpansionCode covered with tests * Load image urls for specific version of card * Correct VSCode debug configuration * Cleaning the code * Add support for art cards * Correct README and * Minor issue in log inside MagicCardService * Fix code for loading cards from file * Fix issue with tag version on release pipeline * Add FilePaths.cs, LanguageCodes.cs, and ILanguageService.cs * Refactor ArchidektPrinter to use IArchidektPrinter interface * Fix issue with getting deck details twice for deck from internet option * Refactor ArchidektPrinter to include language code parameter in GenerateWord method * Refactor MagicCardService to use IMagicCardService interface * Refactor MagicCardService to update card image links with language code * Refactor NLog configuration to use consistent log level and file path * Refactor MagicCardService and repeat search for a card with default criteria if card for given language was not found * Update README * Refactor classes to use interfaces and use records for 3rd party API * Get the related tokens from each card * Add DTOs to keep related token information for a card * Correct README * Add tokens to card list of the deck for printing * Update tokenCopies parameter to be nullable in Program.cs * Update dev branch (#13) * Add support for downloading related tokens (#11) * Refactor CardListFileParser to get Foil Etched and ExpansionCode covered with tests * Load image urls for specific version of card * Correct VSCode debug configuration * Cleaning the code * Add support for art cards * Correct README and * Minor issue in log inside MagicCardService * Fix code for loading cards from file * Fix issue with tag version on release pipeline * Add FilePaths.cs, LanguageCodes.cs, and ILanguageService.cs * Refactor ArchidektPrinter to use IArchidektPrinter interface * Fix issue with getting deck details twice for deck from internet option * Refactor ArchidektPrinter to include language code parameter in GenerateWord method * Refactor MagicCardService to use IMagicCardService interface * Refactor MagicCardService to update card image links with language code * Refactor NLog configuration to use consistent log level and file path * Refactor MagicCardService and repeat search for a card with default criteria if card for given language was not found * Update README * Refactor classes to use interfaces and use records for 3rd party API * Get the related tokens from each card * Add DTOs to keep related token information for a card * Correct README * Add tokens to card list of the deck for printing * Update tokenCopies parameter to be nullable in Program.cs * Update README.md (#12) * Correct displaying app version * Add nlog.config to application assemblies * Correct spacing in dotnet-desktop.yml * Update app version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor classes to use interfaces and use records for 3rd party API
Get the related tokens from each card
Add DTOs to keep related token information for a card
Correct README
Add tokens to card list of the deck for printing
Update tokenCopies parameter to be nullable in Program.cs