Open
Conversation
add these to Midi_ControlSurface::ProcessMidiWidget
Cleanup 'ProcessMidiWidget()' for V1MVUMeter
rename RestoreV1MDisplayColors to RestoreTrackColors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to CSICode
New class V1MVUMeter_Midi_FeedbackProcessor
a) Uses lookup table to determine the LED display, to give more efficient code.
b) This single class removes the duplicity of code from the original 'class QConProXMasterVUMeter_Midi_FeedbackProcessor' and 'class MCUVUMeter_Midi_FeedbackProcessor' into one single class. Therefore if changes are needed only one set of code will need to be modified/tested.
c) Cleaner more efficient code.
New class V1MDisplay_Midi_FeedbackProcessor
a) The Sysex header is generated when the class is instantiated for efficiency.
b) Generally cleaner code.
New class V1MTrackColors_Midi_FeedbackProcessor
a) For efficiency the Sysex header is generated when the class is instantiated and not on each function call.
b) A single function 'SetTrackColors()' as a central point for other functions requiring a colour change.
c) a new function 'SetV1MDisplayColors()' and associated colour lookup table 'rgba_Arr_'
d) Generally cleaner code.
New code in the static DAW class 'control_surface_integrator_Reaper.h' which synchronises the TCP display in Reaper to the surface., i.e. Folder / Spill, and Track mode
Other files
Support files: https://github.com/smarty56/IconV1-M-SupportFiles
Icon IMap file: https://github.com/smarty56/IMAPs