Skip to content

Expanded Time Signatures & Time Changes in-editor. #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Expanded Time Signatures & Time Changes in-editor. #189

wants to merge 8 commits into from

Conversation

Keoiki
Copy link

@Keoiki Keoiki commented May 7, 2025

Associated Funkin PR

Funkin/#4770

Description

Expands the selection of Time Signatures to two separate dropdowns and adds a dropdown for Time Changes.

Other changes:

  • BPM stepper now allows for 3 decimals instead of just 1.
  • The metadata window width is doubled in order to have enough space.

Screenshots/Videos

screenshot-2025-05-08-00-41-12
screenshot-2025-05-08-00-41-23
screenshot-2025-05-08-00-41-28

@Keoiki
Copy link
Author

Keoiki commented May 7, 2025

epic labeler fail

@Hundrec Hundrec added status: pending triage Awaiting review. type: enhancement Provides an enhancement or new feature. size: large A large pull request with more than 100 changes. topic: chart editor Related to the operation of the Chart Editor. labels May 7, 2025
@Keoiki Keoiki mentioned this pull request May 7, 2025
Open
5 tasks
@Keoiki Keoiki force-pushed the more-time-signatures branch from af10dcd to f5325e4 Compare June 17, 2025 11:13
@github-actions github-actions bot added size: huge A huge pull request with more than 500 changes. size: large A large pull request with more than 100 changes. pr: hscript PR modifies game scripts. pr: art PR modifies art or animations. pr: audio PR modifies sound or music. and removed size: large A large pull request with more than 100 changes. size: huge A huge pull request with more than 500 changes. labels Jun 17, 2025
@Keoiki Keoiki changed the base branch from main to develop June 17, 2025 11:13
@Keoiki Keoiki force-pushed the more-time-signatures branch from f5325e4 to ce2038f Compare June 18, 2025 14:40
@github-actions github-actions bot removed pr: hscript PR modifies game scripts. pr: art PR modifies art or animations. pr: audio PR modifies sound or music. labels Jun 18, 2025
@Keoiki Keoiki force-pushed the more-time-signatures branch from ce2038f to 6eff08f Compare June 25, 2025 16:16
@AbnormalPoof AbnormalPoof force-pushed the develop branch 2 times, most recently from e0c19ff to a8d15fe Compare August 2, 2025 15:37
@Keoiki Keoiki force-pushed the more-time-signatures branch from 6eff08f to ab89943 Compare August 2, 2025 16:33
@Keoiki
Copy link
Author

Keoiki commented Aug 2, 2025

Gonna take a wild guess and say the PR label actions stuff shouldn't be there?

@Hundrec
Copy link
Member

Hundrec commented Aug 2, 2025

True...
Trying to fix it right now

@Keoiki Keoiki force-pushed the more-time-signatures branch from ab89943 to 94a4437 Compare August 4, 2025 01:09
@AbnormalPoof AbnormalPoof force-pushed the develop branch 3 times, most recently from e0ba6ab to bcd30e1 Compare August 4, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Keoiki @Hundrec @AbnormalPoof @Lasercar