-
Notifications
You must be signed in to change notification settings - Fork 124
[ENCHANCEMENT] Additional Functionality for Playbars (Assets) #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Trofem
wants to merge
7
commits into
FunkinCrew:main
Choose a base branch
from
Trofem:chart-editor-ui-playbars-enchanced
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
For playbarDifficulty and playbarBPM added /close description. Closing/openning ability added to all other buttons in this order: playbarNoteSnap - Ctrl+Click -> Note Window. playbarSongRemaining - Click -> Offsets Window I think this is optimal!
tooltip="Song Remaining Time/Left Click to open/close Offsets Window"
i hope this is final change for now.
added separate style case for Duration Bar. reacts on hover action from style and used in playbar
its actually Right
9a967df
to
298a3fa
Compare
at least now ok, i do not want make same mistake. |
34fd992
to
c371066
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
size: small
A small pull request with 10 or fewer changes.
status: pending triage
Awaiting review.
topic: chart editor
Related to the operation of the Chart Editor.
type: enhancement
Provides an enhancement or new feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changed playbar.xml and styles.xml files. Now it describes changed logic of playbars, accordingly to #4861 PR changes.
Difficulty:

BPM:

Note Snap

Song Remaining Time:
