Skip to content

[ENCHANCEMENT] Additional Functionality for Playbars (Assets) #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Trofem
Copy link

@Trofem Trofem commented Feb 26, 2025

This PR changed playbar.xml and styles.xml files. Now it describes changed logic of playbars, accordingly to #4861 PR changes.

  • Difficulty:
    image 1

  • BPM:
    image 2

  • Note Snap
    image 3

  • Song Remaining Time:
    image 4

Trofem added 7 commits May 3, 2025 10:20
For playbarDifficulty and playbarBPM added /close description.
Closing/openning ability added to all other buttons in this order:
playbarNoteSnap - Ctrl+Click -> Note Window.
playbarSongRemaining - Click -> Offsets Window
I think this is optimal!
tooltip="Song Remaining Time/Left Click to open/close Offsets Window"
\n added and etc
i hope this is final change for now.
added separate style case for Duration Bar. reacts on hover action from style and used in playbar
@Trofem Trofem force-pushed the chart-editor-ui-playbars-enchanced branch 3 times, most recently from 9a967df to 298a3fa Compare May 3, 2025 10:26
@Trofem
Copy link
Author

Trofem commented May 3, 2025

at least now ok, i do not want make same mistake.
also, actual pr is FunkinCrew/Funkin#4861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: small A small pull request with 10 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants