Custom per-character death names #5229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
Hundrec
added
type: enhancement
funkin.assets
They are specified with the variable "deathName" in the character's .json file, and allow for the pause screen to accurately refer to a character's death animation rather than universally using "Blue Balls." For these purposes, I had Pico's death name be "Blams," and if the given character does not have a pre-defined death name, the game falls back and simply uses "Deaths."
github-actions
bot
added
the
pr: documentation
|
Looks like this PR branch was cloned from main, resulting in two extra commits by me. |
|
Yeah, could you Also, why are the commits commited by Hundrec?????????????????? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #3759
Allows for players to be given custom death names on the pause screen to match their game over screens. These can be added to any player by adding the variable "deathName" to their .json file.
I personally chose to name the statistic "x Blams" for Pico, but if left unspecified for a player, it will just default to "x Deaths", the latter of which can be changed in PlayerData.hx.
EDIT: I know that the .json files should be committed to the assets branch, but I'm honestly not too familiar with Git, plus the fact that it's 4 in the morning, so you'll have to pardon the lack of .json files, at least for now. Again though, adding them manually is trivial, it's literally just a matter of adding a single variable to bf.json and pico.json, so I'm not too worried about it right now.