Chart Editor variation crash fix but better this time #5211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr: haxe
AbnormalPoof
added
type: major bug
|
If you add a line break between the video and any text, it'll display as an embedded video, rather than a link. |
AbnormalPoof
added
type: minor bug
Hundrec
added
type: major bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
None
Description
Currently, the Chart Editor ignores
playData.characters.instrumentalin the metadata when loading a song's instrumental. This PR points it in the right direction.Screenshots/Videos
In this video, I test out base game variations as well as two variations that have no
instrumentalvalue and therefore use the default instrumental.8mb.video-OCE-Mo98A1OQ.mp4