[BUGFIX] Make strumline backgrounds no longer layer over UI elements

[stringfromjava]

this pull request fixes this issue: #4541

fixes mildly annoying layering issues with the strumline backgrounds being layered over the ui

Before...

After!

[AbnormalPoof]

1. This makes the health bar go above the arrows, which inadvertently makes them harder to see. The solution is to make the health bar ABOVE the strumline background, but BELOW the arrows. This makes the logic for the strumline backgrounds way more annoying though.
2. Your code has unnecessary changes that aren't related to the PR. Please revert them.
3. Please change the base branch to develop.

[AbnormalPoof]

These are not necessary.

[AbnormalPoof]

This is not necessary.

[stringfromjava]

after some thinking, why cant we just make the backgrounds their own separate sprites in the playstate? ik that might be frustrating a little bit but thats the only reasonable solution i can really think of (bc as far im thinking abt it, its not really possible to achieve what is wanted unless that happens)

[Lasercar]

The background is in the strumline so that it follows the strumline when it's moved, and hidden when the strum it's attached to is hidden.

[EliteMasterEric]

Yep.

The conundrum here is that since the background is part of the strumline to keep the logic for it simple, but that also means that it's grouped together with the notes.

I'm personally wondering if having the health bar go above the arrows is really that big of a deal, though.

[anysad]

Isn't the whole purpose of the strumline background to lower the amount of distractions so you can focus on the notes? (so that combo, rating and other stuff wouldn't get in the way)

[stringfromjava]

Yep.

The conundrum here is that since the background is part of the strumline to keep the logic for it simple, but that also means that it's grouped together with the notes.

I'm personally wondering if having the health bar go above the arrows is really that big of a deal, though.

i was wondering that too, since it really doesnt have that much of an impact imo

it just looks cleaner to me, plus i dont think anyone would care or even notice whether the arrows were relayered or not :p

[JackXson-Real]

Yep.

The conundrum here is that since the background is part of the strumline to keep the logic for it simple, but that also means that it's grouped together with the notes.

I'm personally wondering if having the health bar go above the arrows is really that big of a deal, though.

Its really not noticeable. There is no way that it will affect anyone's gameplay imo unless they specifically look at the bottom of the screen for some reason (or top if downscroll), but nobody does that. Plus, the health bar is really small anyways, so it really wouldn't get in the way.

[AbnormalPoof]

Still looking for clarification on these:

#5152 (comment)

#5152 (comment)

[stringfromjava]

sorry ive been busy and went out of town. im most likely going home today so ill fix it when i get home (sent thru ny phone)

[stringfromjava]

i have made the requested changes

[stringfromjava]

I have made fixed the merge issues.

[JackXson-Real]

Thanks for fixing the merge conflicts, though I'm surprised it only took you 45 commits to fix them, I'm impressed!

[stringfromjava]

Thanks for fixing the merge conflicts, though I'm surprised it only took you 45 commits to fix them, I'm impressed!

Thank you! I tried my best, I'm new to contributing to public projects, so I'm trying to learn how the system usually works when I try to get a job.