fgOpenGL: check for GL errors after GetCaps #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunNova
commented
Jan 23, 2023
LunNova
force-pushed
the
get-caps-can-fail
branch
3 times, most recently
from
7446cdd to
16cb4d2
Compare
Otherwise, if getting a capability failed a GL error could be left unhandled causing the next operation such as creating a buffer to mysteriously fail. fgOpenGL: Skip retrieving GL_NV_mesh_shader capabilities if it isn't supported
LunNova
force-pushed
the
get-caps-can-fail
branch
from
0371871 to
0831015
Compare
|
I added a check for Still not sure about the approach. |
|
clang-format wrapping from adding the log macro with a long name also looks kinda yuck |
LunNova
added a commit
to LunNova/feathergui
that referenced
this pull request
Feb 11, 2023
…values in GetCaps This is a minimal fix for the issue in Fundament-Software#68. Doesn't try to fix not testing the error state after each individual call there as I still haven't figured out a nice way and noone has suggested one. This at least ensures backendtest works on AMD machines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one of the calls in
GetCapsfailed a GL error could be left unhandled causing the next operation such as creating a buffer to mysteriously fail.On my machine with an AMD card - which doesn't support the
*_NVextensions used inGetCaps- this caused the compute test to fail as the first create buffer call would pick up the leftover error.This feels like more of a bodge than a proper fix as it's logging the error without knowing what to do with it, so I'm leaving this as a draft.
It looks like most places use
CALLGLto handle errors after each GL call, butGetCapsisn't fallible so I can't use that here without changing the interface.