Skip to content

Implement getWorkAdult #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Implement getWorkAdult #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f9e6471
Quick GetChild Implementation (git Fixed)
darthnithin Dec 30, 2024
6093f89
Merge remote-tracking branch 'FujoWebDev/main'
darthnithin Jan 2, 2025
f9bb38e
working but slow implentation of tag categories
darthnithin Jan 3, 2025
c77fcca
iterate over each div instead of doing the backwards traversal
darthnithin Jan 3, 2025
18eb2e2
use cheerio map
darthnithin Jan 3, 2025
388238a
fix capitlization
darthnithin Jan 3, 2025
1404884
Merge branch 'FujoWebDev:main' into main
darthnithin Jan 3, 2025
cadee7d
Merge branch 'FujoWebDev:main' into main
darthnithin Jan 3, 2025
006ae21
Implement GetWorkAdult
darthnithin Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/works/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
getChapterName,
getChapterSummary,
getWorkAdditionalTags,
getWorkAdult,
getWorkAuthors,
getWorkBookmarkCount,
getWorkCategory,
Expand Down Expand Up @@ -66,8 +67,7 @@ export const getWork = async ({
language: getWorkLanguage(workPage),
rating: getWorkRating(workPage),
category: getWorkCategory(workPage),
// TODO: figure out how to get this
adult: false,
adult: getWorkAdult(workPage),
fandoms: getWorkFandoms(workPage),
tags: {
warnings: getWorkWarnings(workPage),
Expand Down
5 changes: 5 additions & 0 deletions src/works/work-getters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,11 @@ export const getWorkLocked = ($workPage: WorkPage) => {
return !!$workPage("#signin > .heading").text();
};

export const getWorkAdult = ($workPage: WorkPage): boolean => {
const adultCategories: WorkRatings[] = [WorkRatings.EXPLICIT, WorkRatings.MATURE, WorkRatings.NOT_RATED];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is a constant, we should define it outside this function like this:

const ADULT_CATEGORIES: WorkRatings[] = [WorkRatings.EXPLICIT, WorkRatings.MATURE, WorkRatings.NOT_RATED];
export const getWorkAdult = ($workPage: WorkPage): boolean => {
// rest of the code

see https://google.github.io/styleguide/tsguide.html#identifiers-constants (but it's a common convention)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I just found out about this: https://mkosir.github.io/typescript-style-guide/#type-safe-constants-with-satisfies

Apparently the best way of declaring this constant would be:

const ADULT_CATEGORIES = [
  WorkRatings.EXPLICIT, 
  WorkRatings.MATURE, 
  WorkRatings.NOT_RATED
] as const satisfies ReadonlyArray<WorkRatings>;

this would give the most correct typing (feel free to ask if you want to understand more).

I'd be ok with keeping it const ADULT_CATEGORIES: WorkRatings[], but since you're changing it let's try the new one?

return adultCategories.includes(getWorkRating($workPage));
}

// Chapter-specific (must be multi-chapter fic)
export const getChapterIndex = (
$workPage: WorkPage
Expand Down
2 changes: 1 addition & 1 deletion tests/work-chapter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ describe("Fetches chapter of work", () => {
language: "English",
rating: "Not Rated",
category: null,
adult: false,
adult: true,
fandoms: ["Batman - All Media Types"],
tags: {
warnings: ["Creator Chose Not To Use Archive Warnings"],
Expand Down