Rework and fix associated const visibility for impl items

[tritao]

Description

Fixes #6772.

Checklist

• I have linked to any relevant issues.
• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • If my change requires substantial documentation changes, I have requested support from the DevRel team
• I have added tests that prove my fix is effective or that my feature works.
• I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
• I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
• I have requested a review from the relevant team or maintainers.

[codspeed-hq]

CodSpeed Performance Report

Merging #6785 will not alter performance

_{Comparing tritao:associated-const-visibility (5f5564b) with master (0a56930)}

Summary

✅ 22 untouched benchmarks

[jjcnn]

I'm still confused by what visibility_level means.

It also took me a while to figure out what problem this PR is supposed to solve in the first place. The PR deccription just links to an issue, but that issue only consists of an example program with no description of what the compiler does incorrectly for that program.

[jjcnn]

Am I right in thinking that consts declared in traits are always public, whereas if they are declared anywhere else they are private unless they have the pub modifier?

[jjcnn]

I suggest moving these lines down to just before we check for visibility_level.is_public(). I'd also like a comment that explains why visibility_level becomes private if resolve_symbol_and_mod_path returns IsSelfType::Yes.

[jjcnn]

Could you update this comment so that it explains what visibility_level means? I'm still confused about it.

Alternatively explain it when visibility_level is declared at the beginning of this function.