Fix handling of associated constants in ABI/traits #6768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
added
the
compiler: frontend
CodSpeed Performance ReportMerging #6768 will not alter performanceComparing Summary
|
tritao
force-pushed
the
non-required-associated-const-values
branch
3 times, most recently
from
05f031e
to
47159fe
Compare
From the reporting issue:
Current implementation of the initialized associated constants in ABIs
and traits is contradictory. Namely, even if we initialize them, we
anyway always have to implement them in the contract or type `impl`s.
This eliminates the whole purpose of being able to initialize them on
the ABI/trait level.
E.g., for ABIs (and the same is for traits):
```
abi ABI {
const CONST: u32 = 111; // <<<--- Initialized here. But this value
cannot be used, because...
}
impl ABI for Contract {
// ... associated constants MUST always be implemented in the
contract/type and initialized anew.
const CONST: u32 = 222; // <<<--- This must be here and this value
wins.
}
```
What we want to have instead, is the same behavior as in Rust. If an
associated constant is already initialized in the ABI or trait
declaration, the `impl`s do not need to provide the constant. If they
do, the value from the `impl` wins. The existing checks for having the
same constant type in the ABI/trait declaration and `impl`s, of course,
remain.
Fixes FuelLabs#6343.
tritao
force-pushed
the
non-required-associated-const-values
branch
from
06ea12e
to
37710f8
Compare
tritao
changed the title
IGI-111
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix handling of initialized associated constants in ABIs and traits.
Fix impl trait associated constant reference wrongly resolving to the ABI value
Fixes #6343 and #6310.
Checklist
Breaking*orNew Featurelabels where relevant.