refactor: transaction estimation flow #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuizAsFight
requested review from
luizstacio,
pedronauck,
helciofranco,
arthurgeron,
rodrigobranas and
nelitow
as code owners
LuizAsFight
changed the title
LuizAsFight
changed the title
LuizAsFight
pushed a commit
that referenced
this pull request
Oct 5, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## @fuels/[email protected] ## [email protected] ### Minor Changes - [#1549](#1549) [`c163db48`](c163db4) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - Increase gasLimit by 20% to avoid OutOfGas error - [#1549](#1549) [`c163db48`](c163db4) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - Refactor transaction estimation / customization of fees flow ### Patch Changes - [#1548](#1548) [`6dd69ceb`](6dd69ce) Thanks [@helciofranco](https://github.com/helciofranco)! - Fix asset list scrollable container when there are many assets available. - [#1543](#1543) [`a64d31f5`](a64d31f) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - chore: test version publish of multiple packages - Updated dependencies \[]: - @fuel-wallet/[email protected] ## @fuel-wallet/[email protected] ## @fuel-wallet/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issues when using Fuel Wallet with SwayLend #1546
Simplified the estimation / approval part of the DAPP Approve Transaction screen
Send transaction part
Refact the transaction estimation part:
initialTxRequestas the one the dev first informed. All further changes will be always done based on this first tx informedproposedTxRequestwhich may have some changesproposedTxRequestis gonna be the one to go for approvalinitialTxRequestand create a newproposetTxRequest, this way we don’t continuously manipulate a transactionRequest. Instead we always have a safe start pointIf the user didn't customize the
gasLimitwe automatically increase 20% on it, avoiding OutOfGas errorsRemove all
minGasLimit, letting the user just inform the gas he wants, if it’s too low the dryRun will failFor the approve screen to start in “Advanced Mode”