Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fn add_fee_input() instead of fn add_random_fee_input() #2211

Closed
wants to merge 6 commits into from

Conversation

rafal-ch
Copy link
Contributor

@rafal-ch rafal-ch commented Sep 17, 2024

Linked Issues/PRs

FuelLabs/fuel-vm#829

Description

The linked fuel-vm PR changes a few functions related to tests.

Note

This PR is blocked - waiting for the new release of fuel-vm containing this change.

@rafal-ch rafal-ch added the no changelog Skip the CI check of the changelog modification label Sep 17, 2024
@rafal-ch rafal-ch marked this pull request as ready for review September 18, 2024 09:10
@rafal-ch rafal-ch requested a review from a team September 18, 2024 09:10
Cargo.toml Outdated
@@ -140,3 +140,6 @@ itertools = { version = "0.12", default-features = false }
insta = "1.8"
tempfile = "3.4"
tikv-jemallocator = "0.5"

[patch.crates-io]
fuel-vm-private = { git = 'https://github.com/FuelLabs/fuel-vm.git', package = "fuel-vm", branch = "master" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should commit patches to master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch removed here.

I added a note to the description saying that this PR is currently blocked and awaiting new fuel-vm release.

@xgreenx
Copy link
Collaborator

xgreenx commented Oct 5, 2024

Close in favor #2299

@xgreenx xgreenx closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants