Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/ripple.Testing/App.config
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="utf-8" ?>
<configuration>
<system.net>
<defaultProxy enabled="true" useDefaultCredentials="true">
</defaultProxy>
</system.net>
</configuration>
26 changes: 25 additions & 1 deletion src/ripple.Testing/Nuget/FloatingFinderTester.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using FubuTestingSupport;
using System.Linq;
using FubuTestingSupport;
using NUnit.Framework;
using NuGet;
using ripple.Model;
Expand Down Expand Up @@ -57,5 +58,28 @@ public void find_the_latest_for_a_fixed_dependency_should_respect_the_upper_boun

result.Found.ShouldBeFalse();
}

[Test]
[Explicit]
public void load_all_packages_from_feed_with_100plus_packages()
{
var feedUrl = Feed.NuGetV2.Url;

var feed = new FloatingFeed(feedUrl, NugetStability.Anything);

Assert.IsTrue(feed.GetLatest().Count() > 100, feedUrl + " has more than 100 packages");
}


[Test]
[Explicit]
public void find_packages_by_name_from_feed_with_100plus_packages()
{
var feedUrl = Feed.NuGetV2.Url;

var feed = new FloatingFeed(feedUrl, NugetStability.Anything);

Assert.NotNull(feed.FindLatestByName("MiniProfiler"), "Package should be on nuget feed " + feedUrl);
}
}
}
12 changes: 12 additions & 0 deletions src/ripple.Testing/Nuget/NugetFeedTester.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,17 @@ public void find_the_async_package()

task.Result.Nuget.Version.ShouldEqual(new SemanticVersion("1.0.1"));
}

[Test]
public void restore_solution_dependencies()
{
var notExistingVersion = new SemanticVersion("1.0.0");
var fixedFeed = new NugetFeed(Feed.NuGetV2.Url, NugetStability.ReleasedOnly);
fixedFeed.Find(new Dependency("Newtonsoft.Json", notExistingVersion, UpdateMode.Float)
{
NugetStability = NugetStability.ReleasedOnly,
Mode = UpdateMode.Float
}).ShouldNotBeNull();
}
}
}
1 change: 1 addition & 0 deletions src/ripple.Testing/ripple.Testing.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@
</ProjectReference>
</ItemGroup>
<ItemGroup>
<None Include="App.config" />
<None Include="Bottles.1.0.0.441.nupkg">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
Expand Down
66 changes: 54 additions & 12 deletions src/ripple/Nuget/FloatingFeed.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,20 @@ public string FindAllLatestCommand
get
{
if(Stability == NugetStability.ReleasedOnly)
return "/Packages()?$filter=IsLatestVersion&$orderby=DownloadCount%20desc,Id&$skip={0}&$top=100";
return "/Packages()?$filter=IsLatestVersion&$orderby=DownloadCount";

return "/Packages()?$filter=IsAbsoluteLatestVersion&$orderby=DownloadCount%20desc,Id&$skip={0}&$top=100";
return "/Packages()?$filter=IsAbsoluteLatestVersion&$orderby=DownloadCount";
}
}

public string FindLatestCommand
{
get
{
if (Stability == NugetStability.ReleasedOnly)
return "/Packages()?$filter=(Id eq '{0}') and IsLatestVersion";

return "/Packages()?$filter=(Id eq '{0}') and IsAbsoluteLatestVersion";
}
}

Expand All @@ -42,7 +53,9 @@ private IEnumerable<IRemoteNuget> loadLatestFeed(int page)

var document = new XmlDocument();
document.LoadXml(text);

var ns = new XmlNamespaceManager(document.NameTable);
ns.AddNamespace("atom", "http://www.w3.org/2005/Atom");
document.SelectSingleNode("//atom:feed", ns);
return new NugetXmlFeed(document).ReadAll(this).ToArray();
}

Expand All @@ -54,15 +67,35 @@ public IEnumerable<IRemoteNuget> GetLatest()
private IEnumerable<IRemoteNuget> getLatest()
{
var all = new List<IRemoteNuget>();
var page = 1;
var results = loadLatestFeed(page);
all.AddRange(results);
while (results.Count() == 100)

const string atomXmlNamspace = "http://www.w3.org/2005/Atom";
var url = Url + FindAllLatestCommand;
var client = new WebClient();

XmlNode nextNode;
do
{
page++;
results = loadLatestFeed(page);
all.AddRange(results);
}
RippleLog.Debug("Retrieving latest from " + url);

var text = client.DownloadString(url);
var document = new XmlDocument();
document.LoadXml(text);
all.AddRange(new NugetXmlFeed(document).ReadAll(this));

var ns = new XmlNamespaceManager(document.NameTable);
ns.AddNamespace("atom", atomXmlNamspace);
nextNode = document.SelectSingleNode("//atom:link[@rel='next']", ns);

if (nextNode != null && nextNode.Attributes != null && nextNode.Attributes["href"] != null)
{
url = nextNode.Attributes["href"].Value;
}
else
{
url = string.Empty;
}

} while (!string.IsNullOrEmpty(url));

return all;
}
Expand All @@ -78,7 +111,16 @@ public override IRemoteNuget FindLatestByName(string name)

protected override IRemoteNuget findLatest(Dependency query)
{
var floatedResult = GetLatest().SingleOrDefault(x => query.MatchesName(x.Name));
var client = new WebClient();

var url = string.Format(Url + FindLatestCommand, query.Name);
var text = client.DownloadString(url);
var document = new XmlDocument();
document.LoadXml(text);

var feed = (new NugetXmlFeed(document).ReadAll(this));

var floatedResult = feed.SingleOrDefault(x => query.MatchesName(x.Name));
if (floatedResult != null && query.Mode == UpdateMode.Fixed && floatedResult.IsUpdateFor(query))
{
return null;
Expand Down
3 changes: 2 additions & 1 deletion src/ripple/Nuget/NugetFeed.cs
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,9 @@ protected override IRemoteNuget find(Dependency query)
}

var versionSpec = new VersionSpec(version);

var package = repository
.FindPackages(query.Name, versionSpec, query.DetermineStability(Stability) == NugetStability.Anything, true)
.FindPackages(query.Name, query.IsFloat()? null: versionSpec, query.DetermineStability(Stability) == NugetStability.Anything, true)
.OrderByDescending(x => x.Version)
.FirstOrDefault();

Expand Down