rc: service.c: adds status, restart, list, exit code and errors reporting#241
Open
wellloaded wants to merge 1 commit intoFreshTomato-Project:arm-masterfrom
Open
rc: service.c: adds status, restart, list, exit code and errors reporting#241wellloaded wants to merge 1 commit intoFreshTomato-Project:arm-masterfrom
wellloaded wants to merge 1 commit intoFreshTomato-Project:arm-masterfrom
Conversation
root@sparrow:/mnt/USB# service help
Usage: service <name> start|stop|restart|status
service list
start Start the service
stop Stop the service
restart Stop then start the service
status Show whether the service process is running
Exit status: 0 on success, 1 on failure.
Run 'service list' for all available service names.
##########################################
- adds "help"
- adds "list" of services
- adds "restart" as an action, reports on pid where relevant
- adds "status" to report on services
- prints an error (instead than the hardcoded Done.) for issues e.g. service didn't restart
- reports error on wrong service names
- reports error on wrong action names
- handles exit codes properly
This change is an enabler for a new "Status / Services <-> status-services.asp" page on the GUI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
root@sparrow:/mnt/USB# service help
Usage: service start|stop|restart|status
service list
start Start the service
stop Stop the service
restart Stop then start the service
status Show whether the service process is running
Exit status: 0 on success, 1 on failure.
Run 'service list' for all available service names.
##########################################
This change is an enabler for a new "Status / Services <-> status-services.asp" page on the GUI