Open
Conversation
Contributor
|
.pyc files should not be included. |
Contributor
|
It seems like we should not capture the reset time in the timing for each script. |
Contributor
Author
|
External timing on the scripts presumes an empty DB. I have been using some shell scripting to narrow log messages to get the precise timings you have seen in the load testing spreadsheet. I will add a |
dmzimmerman
reviewed
Oct 26, 2017
| @@ -0,0 +1,8 @@ | |||
| #!/bin/sh | |||
| ./main.py -u http://192.168.24.43/api/ reset dos_init > 0.log | |||
Member
There was a problem hiding this comment.
Would it make sense to replace these scripts with scripts that take a command line parameter for the hostname?
Contributor
There was a problem hiding this comment.
A parameter would be better. Or my approach in autotest2.sh is to pass an environment variable, $URL.
nealmcb
approved these changes
Dec 4, 2017
Obsoletes 2.sh ... 64.sh, 2-64.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #350 , #351.