Add script to sort glossary entries.#481
Open
cjerdonek wants to merge 2 commits intoFreeAndFair:masterfrom
Open
Add script to sort glossary entries.#481cjerdonek wants to merge 2 commits intoFreeAndFair:masterfrom
cjerdonek wants to merge 2 commits intoFreeAndFair:masterfrom
Conversation
cjerdonek
force-pushed
the
docs-glossary-sort
branch
from
9894cfa to
39b3ff4
Compare
kiniry
requested changes
Aug 26, 2017
Contributor
kiniry
left a comment
kiniry
left a comment
There was a problem hiding this comment.
Let me know what you think. Thanks @cjerdonek!
sort-glossary.py
Outdated
|
|
||
| # Keep the intro at the beginning. | ||
| first_part = parts[0] | ||
| parts = sorted(parts[1:]) |
Contributor
There was a problem hiding this comment.
I think that this should probably read sorted(parts[1:], key=lambda s: s.lower()) and declare the file as Python2.
Author
|
Good point re: case-sensitivity. I half-noticed that but wasn't sure your preference. Done! |
kiniry
approved these changes
Aug 28, 2017
Contributor
kiniry
left a comment
kiniry
left a comment
There was a problem hiding this comment.
Looks great. Thanks, @cjerdonek!
Author
|
No prob! (Btw, FWIW you can also run the script with Python 3, which is what I used.) |
kiniry
modified the milestones:
Phase-2-Amendment-2,
UI/UX polishing & performance and security testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here.
I don't know where you wanted the script, so I just put it at the top level. Also, I noticed there's a redundant file
docs/glossary_concepts.txt, so I removed it.