Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error running package-loading-and-options chunk interactively #249

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

slager
Copy link
Contributor

@slager slager commented Oct 31, 2024

Fixes #242.

Checklist

  • This PR includes unit tests
  • This PR establishes a new function or updates parameters in an existing function
    • The roxygen skeleton for this function has been updated using devtools::document
  • I have updated NEWS.md to describe the proposed changes

@slager slager changed the title tba Fix error running package-loading-and-options chunk interactively Oct 31, 2024
@slager slager requested review from kelliemac and mayerbry October 31, 2024 18:23
@kelliemac
Copy link
Contributor

looks good to me! @mayerbry since you filed the issue that this is intended to fix, can you please review this PR?

Copy link
Contributor

@mayerbry mayerbry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Dave!

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.05%. Comparing base (4bdaa31) to head (0d0b239).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #249   +/-   ##
========================================
  Coverage    82.05%   82.05%           
========================================
  Files            8        8           
  Lines          351      351           
========================================
  Hits           288      288           
  Misses          63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slager slager merged commit 8aacbf7 into develop Jan 8, 2025
8 checks passed
@slager slager deleted the interactive branch January 8, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants