feat(sa_dump_seeds): Add sleep parameter and output seed length #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpelsepp
reviewed
Aug 6, 2024
rumpelsepp
reviewed
Aug 6, 2024
Co-authored-by: Stefan Tatschner <[email protected]>
Co-authored-by: Stefan Tatschner <[email protected]>
rumpelsepp
reviewed
Aug 12, 2024
| @@ -209,6 +219,10 @@ async def main(self, args: Namespace) -> None: | |||
| # Re-enter session. Checking/logging will be done at the beginning of next iteration | |||
| await self.ecu.set_session(session) | |||
|
|
|||
| if args.sleep > 0: | |||
There was a problem hiding this comment.
So above and then:
Suggested change
| if args.sleep > 0: | |
| if args.sleep is not None: |
There was a problem hiding this comment.
The most elegant solution might be this one: Leave the default=0 thing and just remove the if. I think await asyncio.sleep(0) is a noop. Choose your favorite. :)
rumpelsepp
reviewed
Aug 12, 2024
| @@ -84,6 +85,13 @@ def configure_parser(self) -> None: | |||
| default=b"", | |||
| help="Append an optional data record to each seed request", | |||
| ) | |||
| self.parser.add_argument( | |||
| "--sleep", | |||
| default=0, | |||
There was a problem hiding this comment.
nitpick: Remove this, then you can do a not None check below. Would also work better for gallia 2.0 with stricter typing.
Suggested change
| default=0, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sleep parameter as an additional way to attempt fooling brute-force protections. Also outputs the received key length.