Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make scanners respect --no-properties also when connected to a database. #538

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

emedav
Copy link
Contributor

@emedav emedav commented May 13, 2024

Currently, the gallia.protocols.uds.properties configuration option / the --(no-)properties command line flag is only considered for generation of the PROPERTIES_PRE.json and PROPERTIES_POST.json files. As long as the scanner is connected to a database, the properties are nevertheless read from the ECU.

This pull request changes the behavior described above, so that reading the properties from the ECU can be fully disabled.

@emedav emedav requested review from rumpelsepp and peckto as code owners May 13, 2024 12:05
@rumpelsepp rumpelsepp merged commit a308588 into master Jun 20, 2024
11 checks passed
@rumpelsepp rumpelsepp deleted the really-no-properties branch June 20, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants