Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scan-reset): added option to power-cycle on timeout #325

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fkglr
Copy link
Contributor

@fkglr fkglr commented Nov 17, 2022

ECUReset can trigger shutdowns of ECUs which currently leads to TimeoutError, which in turns leads to termination of the scanner.
This commit, introduces the cli option --power-cycle-on-timeout. In case this option is set, the ECU power-cycles the ECU after such a timeout and tries to reconnect to the ECU afterwards.
Tested with isotp and connection-oriented protocols.

Co-authored by @VeroSec and @emedav

@fkglr fkglr force-pushed the scan-reset-power-cycle branch from 8f51f73 to 8a56554 Compare November 17, 2022 15:26
@fkglr fkglr marked this pull request as draft November 17, 2022 15:29
@rumpelsepp
Copy link
Member

We could take the opportunity and refactor this thing. The main() is already way too long.

@rumpelsepp
Copy link
Member

rumpelsepp commented Dec 1, 2022

Payload fuzzer potentially has similar problems; investigate if there is a shared solution. @emedav @VeroSec

@rumpelsepp
Copy link
Member

Reworked in #413.

@rumpelsepp rumpelsepp closed this Jul 14, 2023
@fkglr
Copy link
Contributor Author

fkglr commented Jul 14, 2023

As far as I can see, #413 does not fully include all the cases which are handled here, so I don't think that this should be closed already.
Apart from that I appreciate the uncomplicated way this was handled there and hope that we can also fina a compromise bring this MR to master in the same fashion

@fkglr fkglr reopened this Jul 14, 2023
@rumpelsepp
Copy link
Member

does not fully include all the cases which are handled here

Which one is still missing?

Copy link

stale bot commented Jul 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants