This repository was archived by the owner on Jan 25, 2024. It is now read-only.
Use 'self' if 'root' is undefined #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I try to load libs with `import()`:
```
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<script>
function bootstrap() {
// load all libraries then create & start application
Promise.all([
import("./lib/http_vue_loader.js"),
import("./lib/vue-router.js"),
import("./lib/vue_esm_browser.js"),
]).then(([modLoader, modRouter, modVue, ...other]) => {
debugger;
});
}
window.addEventListener("load", () => bootstrap());
</script>
</head>
<body>
</body>
</html>
```
but `root` is undefined in this case:
```
(function umd(root,factory){
if(typeof module==='object' && typeof exports === 'object' )
module.exports=factory()
else if(typeof define==='function' && define.amd)
define([],factory)
else
root.httpVueLoader=factory()
})(this,function factory() {...});
```
and I have an error "Cannot set property 'httpVueLoader' of undefined" at
```
root.httpVueLoader=factory()
```
`vue-router.js` uses [self](https://developer.mozilla.org/en-US/docs/Web/API/Window/self) in the same situation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to load libs with
import():but
rootis undefined in this case:and I have an error "Cannot set property 'httpVueLoader' of undefined" at
vue-router.jsuses self in the same situation.