-
Notifications
You must be signed in to change notification settings - Fork 8
Brandon King - Project Complete #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bkingo
wants to merge
61
commits into
FractlAgency:master
Choose a base branch
from
bkingo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added basic content, files and folders of the project.
-Added more styling to HTML with Bootstrap classes
-Created tooltip for mobile.
-Fixed issue where the scripts were running before the .csv data had been loaded.
-Increased the height of the banner image at the top with class .bg-banner.
-Changed positioning of the tooltip and the map. -Made modifications to media queries.
-Fixed transition problem where a previously selected state would have its highlighting removed suddenly after changing to a different state.
-Adjusted the opacity of state shapes with the "Percent of Population" (blue) filter.
-This new data has far more accurate values for percent of population. The original ones were way off making it seem like Texas, California, and New York didn't contain as much of the population as they do. The percent of income value has been discarded as it didn't really make sense to begin with. I couldn't find anything online with regard to state statistics that included a "percent of income" category.
-Deleted an extra space after the number for each state's "Median Household Income" value
-Deleted an extra space after the number for each state's "Median Household Income" value
-The changes to the javascript should make make the map display more realistic values and greater color distinction.
-Refactored javascript related the highlighting of state elements, and updating the tooltip, among other things -Fixed bug where the information for DC wouldn't show up in the tooltip -Fixed bug where an abrupt change would happen when the user would select DC or select another state from the dropdown with DC already selected -Added functionality to the Top 5 section so that it will display the top 5 states for each category depending on the radio button that is selected.
-Problem in Safari was that the as the user used the dropdown menu to select states, the previous ones were not being deselected -Modified "setBorderHighlight" function to be more easily understood (hopefully by browser)
-Second tooltip for created for desktop devices where states are highlighted after the cursor passes over them. The tooltip will adjust it's position as the mouse moves over the state elements. -Made CSS more maintainable by removing a few useless classes. -A few other tweaks *At this point I believe that the project is pretty much complete*
-Minor edit to data visualization project text
-Commented out the title element in the SVG element as it was causing an unnecessary title box to show up on Windows
-HTML and Javascript files were updated so that booth the tooltip and on mobile and for desktop will now include the state name for clarity.
- I did not think that I would continue working on this project after January had passed but now I think I will complete Part 2 as soon as I can using the charts.js library. I still intend for the US map to be the only part from this project featured on my portfolio at my portfolio site www.brandonking.io/. -The HTML file for the pie chart will be in the "piechart.html" file, which may require downloading the project to access in the browser.
-Added header with title section and basic styling with colors, etc.
-Changed font color of legend, added border to header tagline and margin to first graph, etc... - Put a link in Part 1 of the assessment to my project for Part 2
-Added meta tag to html file to allow for proper responsive behavior -Shifted position of a few tags in the <head> tag
…tionality - User can now switch between the data for the men and the women by clicking on the corresponding button - Project should now look at least decent on larger screen sizes *problem occurred when trying to float the container holding the graphs*
Author
|
Project is now complete |
…g highlighted prematurely
modified setBorderHighlight( ) function
more changes for premature highlighting problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Project is still unfinished. Still working on part 1.