Fix planner sanity check #3657
Open
Fix planner sanity check #3657
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normen662
requested changes
Oct 2, 2025
| requestedOrderingParts.stream() | ||
| .allMatch(requestedOrderingPart -> requestedOrderingPart.getValue() | ||
| .getResultType().isPrimitive()))); | ||
| .getResultType().isPrimitive() || requestedOrderingPart.getValue().getResultType().isUuid()))); |
There was a problem hiding this comment.
Sorry, I do not agree with this fix. The check makes sure that you never order by something that is not primitive. Isn't a UUID a structure? What happens if I want to order by a UUID column? That should be broken up just like other records should be broken up.
There was a problem hiding this comment.
With #3198 we already added support for UUID as a primitive type in SQL. There is special handling of massaging TupleFieldsProto.UUID messages in the planning and execution codepath (that's what the majority of that PR was about).
There was a problem hiding this comment.
Is there a reason that the requestedOrderingPart.getResultType().isPrimitive() doesn't return true if the type is a UUID?
normen662
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This amends a planner sanity check which verifies that only primitive types are allowed when constructing an ordering such that it also accepts UUIDs.
This fixes #3656.