Skip to content

Conversation

normen662
Copy link
Contributor

No description provided.

* @return a {@link String} containing the hexadecimal representation of the byte array passed in
*/
@Nonnull
static String bytesToHex(byte[] bytes) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be shared with the NodeHelpers one?

@@ -1,5 +1,5 @@
/*
* NodeHelpers.java
* HNSWHelpers.java
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an accident.

option java_outer_classname = "TestFieldTypeChangeProto";

import "record_metadata_options.proto";
//import "record_metadata_options.proto";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? What was broken?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what happened. I changed something somewhere in a test proto file and suddenly got all these warnings about unnecessary imports. And since we run everything in -Werror...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants