Fix calendar handling of pre-1970 birthdates

[LFd3v]

Re submit PR #224, all credits to @TristanDonze.

I cannot do a build right now, but I can more than happily test a beta build if needed (and update the PR with any necessary changes if required, of course).

What is it?

• Bugfix
• Feature
• Codebase improvement

Description of the changes in your PR

• Removed lines of code.

Before/After Screenshots/Screen Record

• Please refer to Fix calendar handling of pre-1970 birthdates #224

Fixes the following issue(s)

• Fixes Age incorrect for private contacts from Fossify Contacts who are born before 1970 #196

Acknowledgement

• I read the contribution guidelines.

[naveensingh]

I cannot do a build right now, but I can more than happily test a beta build if needed.

A test build should be available under checks tab soon :)

[LFd3v]

A test build should be available under checks tab soon :)

Awesome. I did not see any potential side effects, but running a test build is always a good idea. Thanks and sorry for the trouble.

[LFd3v]

Hmm, I think now I understand why the check for years before 1970 was added: for events (birthdays or anniversaries) without an year, the age is calculated using the year 1604, resulting in ages like 420 years for these events in 2024, for instance. Anyway, limiting the date to 1970 is even worse IMHO...

1. Probably the best solution would be not printing the age for events without an year, of course. But then it will require more changes and tests.

2. A simpler solution would be checking for the full year, and set it to the current year so the age would be zero. I can try to implement this.

@naveensingh Thoughts? Do you want me to simply add a TODO to remind about item 1) or try to do 2)?

[naveensingh]

Probably the best solution would be not printing the age for events without an year, of course. But then it will require more changes and tests.

This is the way. I don't think we need a lot of changes for it, just adding FLAG_MISSING_YEAR flag to the birthday event should do the job as this is already implemented for public contacts (see addContactEvents()).

var missingYear = false
// private contacts are created in Simple Contacts Pro, so we can guarantee that they exist only in these 2 formats
val format = if (birthdayAnniversary.startsWith("--")) {
     missingYear = true
     "--MM-dd"
} else {
    "yyyy-MM-dd"
}

var flags = if (missingYear) {
    FLAG_ALL_DAY or FLAG_MISSING_YEAR
} else {
    FLAG_ALL_DAY
}

// use flags...

I have not tested this but it should work.

[LFd3v]

Oh, great. I missed the block above for other events, it indeed seems to handle events without an year properly.

I was going to ask to to trigger a new build in my fork, but it seems that it was triggered here already. I hope it works fine now!

[LFd3v]

It seems to be working just fine:

• events before 1970 now display the correct age
• events with hidden year now have the age hidden in the app
• no crashes or other visible glitches

Just a remark: in the release notes, it may be a good idea to point out that birthdays and anniversaries will have to be imported again so the Calendar app will display them properly.

Cheers!

[naveensingh]

Great, thanks!