This repository was archived by the owner on Feb 19, 2022. It is now read-only.
[EXPERIMENT] VictorySelectionContainer (don't merge) #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbolin
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big change is that
onMouseMovedoes not use the victory event system; instead it simply uses a function that manipulates local state of the container.Big question: Could we make the Victory Event System this fast?
Demo at http://localhost:3000/#/performance. This demo shows both
VictorySelectionContainerand new "VictorySelectionContainerX", with 2000 points each. The only change in performance is during mouse moves. On my machine this when from 4.8 FPS to 11.5 FPS.We would need some sort of "hint" to in an event to say "this only modifies the parent, not anything else." In this case
onMouseMovehas no effects to data or labels, so none of that calculation should have to be done.(Obvious disclaimer: this is a hacky experiment. It uses a global var to allow the static
defaultEventsto call a instance method.)