-
Notifications
You must be signed in to change notification settings - Fork 18
Fix/metro exports and hook import #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zibs
wants to merge
11
commits into
main
Choose a base branch
from
fix/metro-exports-and-hook-import
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* expo module * expo module * Initial iOS & Android error check implementation * Prettier fix * move example to playground * make clear error * improve playground app
* fixes to get AMA playground running. still WIP * fix build
- Fix exports field in all packages: replace invalid "imports" condition with proper "import" condition - Add comprehensive export conditions (react-native, import, require, types, default) for better compatibility - Add "./package.json" export to all packages for module resolution - Fix direct subpath import in usePressable.ts to use main package export instead of internal path
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Update install-state.gz
…Script warnings - Remove broken exports array syntax that used invalid "imports" field - Replace with proper conditional exports object using "types" and "default" fields - Point all consumers to compiled JavaScript (dist/) instead of TypeScript source - Keep "react-native" field pointing to source for Metro bundler compatibility - Fix inconsistent dist paths (core package used dist/src/, others used dist/) This resolves Babel warnings about TypeScript type exports (FormActions, FormFieldProps, etc.) not being declared in scope tracker. The previous exports configuration was malformed and caused consuming apps' Babel to process TypeScript type-only exports incorrectly. By directing all consumers to compiled JavaScript output, we ensure: - Types are properly stripped during compilation - Consistent behavior across all JavaScript environments - No Babel confusion with TypeScript type-only exports - Maintains React Native source access via "react-native" field
it seems like this was just typed wrong, it's an object with an `{issues: [], timestamp: 'string'}` shape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using this library at latest on a project causes some warnings in the terminal about some module imports/exports and I found a few issues digging into it.
From the commit message:
Type of Change
How Has This Been Tested?
Checklist: (Feel free to delete this section upon completion)