Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKS-3772 Revoke and terminate the session when it does not match the existing session. #469

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

witrisna
Copy link
Contributor

@witrisna witrisna commented Feb 3, 2025

JIRA Ticket

SDKS-3772

Description

SDKS-3772 Revoke and terminate the session when it does not match the existing session.

@witrisna witrisna requested a review from spetrov February 3, 2025 18:52
@witrisna witrisna self-assigned this Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.36%. Comparing base (3d89718) to head (5b9c472).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...rg/forgerock/android/auth/DefaultTokenManager.java 41.66% 7 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #469      +/-   ##
=============================================
- Coverage      64.41%   64.36%   -0.05%     
- Complexity      1670     1671       +1     
=============================================
  Files            256      256              
  Lines           8653     8661       +8     
  Branches         921      920       -1     
=============================================
+ Hits            5574     5575       +1     
- Misses          2667     2673       +6     
- Partials         412      413       +1     
Flag Coverage Δ
unit-tests 64.36% <46.15%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@spetrov spetrov merged commit cae899f into develop Feb 4, 2025
9 of 12 checks passed
@spetrov spetrov deleted the SDKS-3772 branch February 4, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants