Fix AbsolutePath.Exists() to check for both files and directories #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, AbsolutePath.Exists() only checked for file existence using File.Exists(), which returned false for directories. This caused issues when checking if a directory path exists. Changes: - Modified Exists() to check for both files and directories (File.Exists() || Directory.Exists()) - Added explicit ExistsFile() method for checking file existence only - Kept ExistsDirectory() unchanged for directory-specific checks This allows Exists() to correctly return true for any filesystem entity (file or directory), while still providing explicit methods for type-specific existence checks. Fixes ForNeVeR#171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AbsolutePath.Exists()to check for both file and directory existenceExistsFile()method for file-only checksExistsDirectory()method unchangedChanges Made
Modified
TruePath.SystemIo/PathIo.cs:Exists()implementation fromFile.Exists(path.Value)toFile.Exists(path.Value) || Directory.Exists(path.Value)ExistsFile()method that checks only for file existence:File.Exists(path.Value)Exists()to reflect that it now checks for both files and directoriesProblem Solved
Previously, calling
folder.Exists()on a directory path would returnfalseeven if the directory existed, because the method only usedFile.Exists(). This broke code that needed to check if a path (file or directory) exists before performing operations like deletion.With this fix:
Exists()returnstruefor any existing filesystem entity (file or directory)ExistsFile()explicitly checks for files onlyExistsDirectory()explicitly checks for directories onlyFixes #171