Skip to content

Conversation

@DrRataplan
Copy link
Contributor

Without that, the namespace part is never picked up

Fixes #679

Without that, the namespace part is never picked up
@bundlemon
Copy link

bundlemon bot commented Sep 1, 2025

BundleMon

Files updated (2)
Status Path Size Limits
fontoxpath.js
78.61KB (-341B -0.42%) -
fontoxpath.esm.js
78.72KB (-346B -0.43%) -

Total files change -687B -0.42%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@DrRataplan
Copy link
Contributor Author

Looks like my access to FontoXPath is revoked again.

@coveralls
Copy link

Coverage Status

coverage: 91.576%. remained the same
when pulling 7573bdf on DrRataplan:fix/instance-of-namespaces
into d5ac004 on FontoXML:master.

Copy link
Member

@bwrrp bwrrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subtle bug, nice catch!

@DrRataplan
Copy link
Contributor Author

DrRataplan commented Dec 2, 2025

@bwrrp since my push access is revoked, could you get this merged? Just ran into this bug again...

@bwrrp bwrrp merged commit 9fe4afc into FontoXML:master Dec 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

instance of returns false if namespaces are in play

3 participants