Skip to content

Add export for imrotate gradient #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CarloLucibello merged 1 commit into from
Apr 12, 2024
Merged

Add export for imrotate gradient #574

CarloLucibello merged 1 commit into from
Apr 12, 2024

Conversation

@roflmaostc
Copy link
Contributor

@roflmaostc roflmaostc commented Apr 12, 2024

I think we should have added the export for \nabla imrotate in #553?

mcabbott
mcabbott approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@mcabbott mcabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nnlib exports this for softmax:

NNlib.jl/src/NNlib.jl

Line 55 in 0783363

export softmax, softmax!, ∇softmax, ∇softmax!, logsoftmax,

So I don't see why not here too. It's very unlikely to collide with anything from elsewhere.

@CarloLucibello CarloLucibello merged commit d85402a into FluxML:master Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcabbott mcabbott mcabbott approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roflmaostc @mcabbott @CarloLucibello