Skip to content

Conversation

@VarLad
Copy link

@VarLad VarLad commented Dec 8, 2025

imports and re-exports OpenCL from MLDataDevices, for usage in Flux.jl
Depends on LuxDL/Lux.jl#1590

@VarLad
Copy link
Author

VarLad commented Dec 8, 2025

Marking as draft until the MLDataDevices PR is merged

@VarLad VarLad marked this pull request as draft December 8, 2025 08:52
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.93%. Comparing base (64c3979) to head (5af3c22).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2635       +/-   ##
===========================================
+ Coverage   32.09%   65.93%   +33.84%     
===========================================
  Files          32       33        +1     
  Lines        2038     2087       +49     
===========================================
+ Hits          654     1376      +722     
+ Misses       1384      711      -673     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VarLad VarLad marked this pull request as ready for review December 11, 2025 00:11
@VarLad
Copy link
Author

VarLad commented Dec 11, 2025

@CarloLucibello Should I bump the minimum required version of MLDataDevices as well?

@CarloLucibello
Copy link
Member

Should I bump the minimum required version of MLDataDevices as well?

yes.

Can we add some tests, e.g. for Dense forward and backward passes?

@VarLad
Copy link
Author

VarLad commented Dec 13, 2025

@CarloLucibello will these be good enough?
I'm not sure how to enable them in CI though 😓
But no special machine should be required, since its using the CPU backend (provided as a jll) in the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants