Open
Conversation
87bc4bf to
1b84589
Compare
590ed89 to
db797c5
Compare
Collaborator
Author
|
Notes on the newly added localization files: This change is actually part of breaking changes to Flutter tooling which going forward won't generate the That's why we've these new localization files showing up in the app directory on pub get on master. More details on the breaking change is here, First seen in : Seen in master on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Fix] Fixes editor crash (Resolves #2604)
The editor crash occuring during the placeholder insertion after an attributed text was result of a bug in markdown finder flow,
findMarkdownwithin_UpstreamInlineMarkdownParser. The offset at which the placeholder was getting inserted, couple of places within the markdown finder were expecting a string at that offset but were receiving an instance of the placeholder resulting in a crash.Fixed this by passing the plain text version of the
attributedTextbefore performing any operations that try to parse/work with theattributedText.Demo:
Screen.Recording.2025-04-17.at.9.03.54.AM.mov
Remarks: