feat(countdown-timer): add onExpire callback to match sibling (FlowwStar/FlowStar#384) - #389
Open
jdjioe5-cpu wants to merge 1 commit into
Open
feat(countdown-timer): add onExpire callback to match sibling (FlowwStar/FlowStar#384)#389jdjioe5-cpu wants to merge 1 commit into
jdjioe5-cpu wants to merge 1 commit into
Conversation
…lowwStar#384) Closes FlowwStar#384. Adds an optional `onExpire` callback prop to CountdownTimer, keeping its API consistent with AccessibleCountdownTimer. Implementation uses a useRef flag (firedRef) to guarantee exactly-one invocation per active->expired transition even across re-renders or target mutations. - Adds `onExpire?: () => void` to CountdownTimerProps - Re-arms firedRef when target transitions back to active - Same prop ordering / typing shape as AccessibleCountdownTimer's onStateChange, so a future migrate-to-consistency refactor is mechanical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #384.
Change
components/ui/countdown-timer.tsx:onExpire?: () => voidtoCountdownTimerProps.useRefflag(
firedRef). Re-arm when the timer transitions back to active.formatTimeRemaining/useNowbehaviour.Why this shape
onStateChangecallback pattern butfiltered to the one transition (active → expired) that an anonymous
countdown consumer actually wants — keeps the public API of the simpler
CountdownTimerlean.onStateChangein later without breaking the new
onExpireshape.