feat: breadcrumbs, keyboard a11y, SECURITY.md, and ADRs#190
Merged
Austinaminu2 merged 2 commits intoJun 27, 2026
Conversation
Closes FlowwStar#169 — add Breadcrumb component with responsive truncation, accessible <nav aria-label="Breadcrumb"> / <ol> markup, dynamic route support, and integration into the app shell layout. Closes FlowwStar#172 — keyboard navigation audit: fix NetworkMismatchModal (broken <a> tag, add focus trap + Escape + auto-focus + focus restore); add Escape key + aria-expanded + focus restore to NotificationBell; rewrite CommandPalette with FocusTrap component, autoFocus on input, and focus restoration; add global :focus-visible ring via CSS. Closes FlowwStar#178 — add SECURITY.md with scope, private reporting process, response timeline, severity classification, safe harbor, and README link. Closes FlowwStar#179 — add docs/adr/ with index, template, and 7 ADRs covering persistent storage, client-side unlock math, mock mode, polling strategy, bigint amounts, Freighter wallet strategy, and integer division dust. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@Ndifreke000 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves four issues in one branch:
#169 — Breadcrumb navigation
components/layout/breadcrumb.tsx—'use client'component that readsusePathname()and builds a crumb trail from the URL segments<nav aria-label="Breadcrumb">+<ol>for accessible markup<span aria-current="page">(not a link)max-w+truncate/app/stream/[id]) with a human-readable label fallbackapp/app/layout.tsxbetween<Navbar />and<main>#172 — Keyboard navigation audit
NetworkMismatchModal— fixed broken<a>tag (was missing<a), added focus trap (Tab cycles within modal), Escape closes + restores focus, auto-focuses dismiss button on mount, cleanup on unmountNotificationBell— addedrefto trigger button, Escape key handler closes panel and restores focus to trigger,aria-expanded+aria-haspopupattributes,focus-visible:ringon all interactive elements inside the panelCommandPalette— rewritten with a reusableFocusTrapcomponent (Tab/Shift+Tab cycles, Escape fires callback),autoFocuson the command input, focus restoration to the element that opened the palette, dark-mode classes, corrected internal routes to/app/*app/globals.css— added@layer base { :focus-visible { ... } }rule to enforce a visible ring on all focusable elements in both light and dark themes#178 — SECURITY.md
SECURITY.mdat the repo root with: in-scope/out-of-scope definition, private reporting process (GitHub Security Advisories preferred), response timeline (acknowledgment 48h → fix 72h–2w by severity), severity classification table (Critical → Low), safe harbor statement, and note on bug bountyREADME.md#179 — Architecture Decision Records
docs/adr/withREADME.mdindex andADR-000-template.mdREADME.md🤖 Generated with Claude Code