Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP TASK: Further improvements for the 1and1 project #33

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
b77c2b7
BUGFIX: Show module icon in module list
Sebobo Jan 19, 2023
fb3ee84
BUGFIX: Prevent tailwind from breaking neos backend styles
Sebobo Jan 19, 2023
5e53d53
BUGFIX: Prevent metadata from loosing its workspacename
Sebobo Jan 20, 2023
6b25d92
FEATURE: Set build lock by workspace to allow parallel releases
Sebobo Jan 20, 2023
8b5f110
TASK: Show rendering error details in render_orchestrator output
Sebobo Jan 20, 2023
d39ef93
BUGFIX: Flush content cache when the pipeline actually starts
Sebobo Feb 1, 2023
28f7d2f
FEATURE: Allow recursing through hidden documents
Sebobo Feb 14, 2023
efc5811
add configuration to enable/disable auto-start of incremental releases
erickloss Feb 22, 2023
eb2bca8
BUGFIX: Use workspace name from enumerated node during rendering
Sebobo Apr 19, 2023
b0aabd7
BUGFIX: Enable storing rendered documents in non public workspaces
Sebobo Apr 19, 2023
a0de60d
BUGFIX: Prevent exception in overview when ContentReleaseMetadata is …
Sebobo May 2, 2023
477108a
TASK: Add rendertime to render orchestrator output
Sebobo May 16, 2023
4876ca0
BUGFIX: Prevent error when exception has no referenceCode
Sebobo Jul 10, 2023
f3f7110
BUGFIX: Prevent creating a second content release with the same id
Sebobo Jul 19, 2023
7ce1709
FEATURE: Store rendertime of documents in metadata
Sebobo Oct 9, 2023
8bafbae
BUGFIX: Prevent error when viewing content releases with no Redis met…
Sebobo Nov 9, 2023
a15d22e
FEATURE: Log enumeration duration for each site
Sebobo Nov 14, 2023
8e20be9
BUGFIX: Speed up enumeration by fetching all documents with one query
Sebobo Nov 14, 2023
9e988aa
TASK: Cache redis instance for repeated calls in CacheReader
Sebobo Nov 15, 2023
3816e27
FEATURE: Allow enumeration of any nodetype
Sebobo Nov 15, 2023
a59129f
TASK: Optimise redis content cache reader
Sebobo Nov 16, 2023
b07abbc
TASK: Cleanup enumeration code
Sebobo Nov 22, 2023
ba2248f
TASK: Reformat NodeEnumerator code
Sebobo Nov 28, 2023
74157bf
BUGFIX: Add html escaping to stderr and stdout of job logs
mhsdesign Dec 7, 2023
a737e87
Merge pull request #35 from Flowpack/bugfix/error-logs-html-escaping
Sebobo Dec 7, 2023
ce64170
FEATURE: Make iteration checks in NodeRenderer configurable
Sebobo Dec 11, 2023
cb4128d
Merge branch 'task/adjustments-for-1and1' of https://github.com/Flowp…
Sebobo Dec 11, 2023
dbb3705
TASK: Append payload only in logging if set
Sebobo Dec 12, 2023
9e887c9
TASK: Add newlines to log output
Sebobo Dec 12, 2023
a639800
BUGFIX: Remove pretty formatting for payloads again
Sebobo Dec 12, 2023
f68938e
BUGFIX: Make NodeRenderer constants overridable
Sebobo Dec 12, 2023
53db941
TASK: Forgiving data handling in ui service
mhsdesign Dec 20, 2023
aab5a6d
BUGFIX: Joblogs preserve whitespace and highlight errors
mhsdesign Jan 17, 2024
11a2a2b
TASK: Reverse stdout log and improve styling
Sebobo Jan 17, 2024
71a4ac5
Merge pull request #36 from Flowpack/bugfix/joblogs-preserve-whitespa…
Sebobo Jan 17, 2024
d62e013
FEATURE: Format stdout with eel helper
Sebobo Apr 15, 2024
7d576fe
BUGFIX: Handle empty stdout when formatting logs
Sebobo Apr 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TASK: Append payload only in logging if set
Sebobo committed Dec 12, 2023

Verified

This commit was signed with the committer’s verified signature.
Sebobo Sebastian Helzle
commit dbb37059ba19d02afdf9256b77cf7101989dc5c7
22 changes: 14 additions & 8 deletions Classes/Core/Infrastructure/ContentReleaseLogger.php
Original file line number Diff line number Diff line change
@@ -47,24 +47,30 @@ public static function fromSymfonyOutput(OutputInterface $output, ContentRelease
return new static($output, $contentReleaseIdentifier, null);
}

public function debug($message, array $additionalPayload = [])
public function debug($message, array $additionalPayload = []): void
{
$this->output->writeln($this->logPrefix . $message . json_encode($additionalPayload));
$this->logToOutput($message, $additionalPayload);
}

public function info($message, array $additionalPayload = [])
public function info($message, array $additionalPayload = []): void
{
$this->output->writeln($this->logPrefix . $message . json_encode($additionalPayload));
$this->logToOutput($message, $additionalPayload);
}

public function warn($message, array $additionalPayload = [])
public function warn($message, array $additionalPayload = []): void
{
$this->output->writeln($this->logPrefix . $message . json_encode($additionalPayload));
$this->logToOutput($message, $additionalPayload);
}

public function error($message, array $additionalPayload = [])
public function error($message, array $additionalPayload = []): void
{
$this->output->writeln($this->logPrefix . $message . json_encode($additionalPayload));
$this->logToOutput($message, $additionalPayload);
}

protected function logToOutput($message, array $additionalPayload = []): void
{
$formattedPayload = $additionalPayload ? json_encode($additionalPayload, JSON_PRETTY_PRINT) : '';
$this->output->writeln($this->logPrefix . $message . $formattedPayload);
}

public function logException(\Exception $exception, string $message, array $additionalPayload)