Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds autocomplete attribute to login username field #4774

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

knolleary
Copy link
Member

Adds autocomplete="username" to the login field.

This required adding support for autocomplete as a property of ff-text-input.

@knolleary knolleary requested a review from cstns November 14, 2024 15:28
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (0b4c35f) to head (d327dfa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4774   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         311      311           
  Lines       14782    14782           
  Branches     3385     3385           
=======================================
  Hits        11647    11647           
  Misses       3135     3135           
Flag Coverage Δ
backend 78.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 58a1c56 into main Nov 14, 2024
11 of 12 checks passed
@knolleary knolleary deleted the add-autocomplete-to-username branch November 14, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants