-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Device Group env vars API support #4659
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4659 +/- ##
==========================================
+ Coverage 78.53% 78.59% +0.06%
==========================================
Files 303 304 +1
Lines 14399 14470 +71
Branches 3285 3303 +18
==========================================
+ Hits 11308 11373 +65
- Misses 3091 3097 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - one pending question about a commented out function. Approved pending resolution of the question.
Add UI for Device Group Env Setup
Thanks Nick. I will do final a ux test on pre-staging instance & use that to grab screenshots for changelog. Once I get docs done & approved, I'll merge this. |
closes #4658
Description
Route added
PUT
/api/v1/applications/:applicationId/device-groups/:groupId/settings
env
array of objectsNOTE: Adding endpoint vs updating the
PUT /api/v1/applications/:applicationId/device-groups/:groupId
routewas a toss of a coin. Instances overload the
PUT /api/v1/projects/:id
route allowing for thesettings to be updated in the same request. However, devices have a separate route
PUT /api/v1/devices/:deviceId
route.Since devices and device groups are closer in relation, I decided to follow suit. I did however structure this is a way that we can easily remove this endpoint and map the feature to the existing route if so desired
Specified behaviour
application:device-group:update
permission was re-used for this purposeenv
array of objects is merged with the existing member devices only in thelive
API (when a device is requesting settings)settings
and saving will trigger all member devices to update their settings hashTests added
Related Issue(s)
Owner: #4658
Parent: #4538
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label