Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team broker client UI #4646

Merged
merged 59 commits into from
Oct 24, 2024
Merged

Team broker client UI #4646

merged 59 commits into from
Oct 24, 2024

Conversation

hardillb
Copy link
Contributor

fixes #4433

Description

Starts to add the UI for adding Broker Clients

Still needs a lot of work

#1350

Related Issue(s)

#4433

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Still needs create, delete and edit hooking up
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.74%. Comparing base (9f6fc28) to head (9d7eb76).
Report is 60 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4646   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files         311      311           
  Lines       14669    14669           
  Branches     3354     3354           
=======================================
  Hits        11551    11551           
  Misses       3118     3118           
Flag Coverage Δ
backend 78.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb
Copy link
Contributor Author

@joepavitt this is functional enough for me to test things, but needs a lot of love.

I also need to write the backend API for edits to the ACL and to allow password changes. Will get those done tomorrow.

@joepavitt
Copy link
Contributor

@cstns how you looking on Visual History? Need me to jump in here, or could you finish both, visual history and this by Thursday next week?

@cstns
Copy link
Contributor

cstns commented Oct 16, 2024

I think I could tackle both! My best guess is that the Visual History ui will be done by the end on this week and can jump to this one afterwards.

@hardillb
Copy link
Contributor Author

Couple of points

  • create/edit/delete should only be available to team owner
  • dashboard only users should not have access

@cstns cstns self-assigned this Oct 16, 2024
@hardillb
Copy link
Contributor Author

Also when displaying the username, it should have @[teamHashId] added to the end.

e.g. is username alice is created in a team with a hash id of 1234abc then the username should be displayed as alice@1234abc

Might be worth adding another dialog shown after creating a user that shows the username (and client id with the same value) and the topics.

@hardillb
Copy link
Contributor Author

fixed the empty state

image

@cstns
Copy link
Contributor

cstns commented Oct 23, 2024

fixed the empty state

image

Was just about to do so, spotted it whilst writing e2e tests.

I took the liberty to make the logo smaller and add some accompanying text

@cstns
Copy link
Contributor

cstns commented Oct 23, 2024

I'll mark the e2e selector changes as resolved and take care of them on the follow up task

@cstns
Copy link
Contributor

cstns commented Oct 23, 2024

created #4685 as a follow up task. Feel free to add things that I may have missed

@hardillb hardillb dismissed joepavitt’s stale review October 24, 2024 07:45

Joe is out today and follow up task added to fix test selectors

@hardillb hardillb merged commit f52c2cc into main Oct 24, 2024
14 checks passed
@hardillb hardillb deleted the team-broker-client-ui branch October 24, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Design: provisioning & using MQTT Service
3 participants