-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Team broker client UI #4646
Team broker client UI #4646
Conversation
Still needs create, delete and edit hooking up
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4646 +/- ##
=======================================
Coverage 78.74% 78.74%
=======================================
Files 311 311
Lines 14669 14669
Branches 3354 3354
=======================================
Hits 11551 11551
Misses 3118 3118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Still needs create, delete and edit hooking up
…lowfuse into team-broker-client-ui
@joepavitt this is functional enough for me to test things, but needs a lot of love. I also need to write the backend API for edits to the ACL and to allow password changes. Will get those done tomorrow. |
@cstns how you looking on Visual History? Need me to jump in here, or could you finish both, visual history and this by Thursday next week? |
I think I could tackle both! My best guess is that the Visual History ui will be done by the end on this week and can jump to this one afterwards. |
Couple of points
|
Also when displaying the username, it should have e.g. is username Might be worth adding another dialog shown after creating a user that shows the username (and client id with the same value) and the topics. |
…lowfuse into team-broker-client-ui
…-broker-client-ui # Conflicts: # frontend/src/pages/team/Broker/index.vue
test/e2e/frontend/cypress/tests/instances/version-history/snapshots.spec.js
Show resolved
Hide resolved
test/e2e/frontend/cypress/tests/instances/version-history/snapshots.spec.js
Show resolved
Hide resolved
test/e2e/frontend/cypress/tests/instances/version-history/snapshots.spec.js
Show resolved
Hide resolved
test/e2e/frontend/cypress/tests/instances/version-history/snapshots.spec.js
Show resolved
Hide resolved
test/e2e/frontend/cypress/tests/instances/version-history/snapshots.spec.js
Show resolved
Hide resolved
I'll mark the e2e selector changes as resolved and take care of them on the follow up task |
created #4685 as a follow up task. Feel free to add things that I may have missed |
Joe is out today and follow up task added to fix test selectors
fixes #4433
Description
Starts to add the UI for adding Broker Clients
Still needs a lot of work
#1350
Related Issue(s)
#4433
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label