Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify "Push to stage" dialog env var statement #4604

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Oct 2, 2024

closes #4603

Description

Clarify "Push to stage" dialog env var statement

Before:

image

After:

image

Related Issue(s)

#4603

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns
Copy link
Contributor

cstns commented Oct 2, 2024

Feel free to merge after tests pass

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.74%. Comparing base (f52c2cc) to head (059c0a2).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4604   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files         311      311           
  Lines       14669    14669           
  Branches     3354     3354           
=======================================
  Hits        11551    11551           
  Misses       3118     3118           
Flag Coverage Δ
backend 78.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Steve-Mcl
Copy link
Contributor Author

Steve-Mcl commented Oct 2, 2024

Thanks @cstns appreciate quick feedback.

Hoping to also get the "OK" from @joepavitt and perhaps @sumitshinde-84 too since it arose from confusion in the new pipelines article here: FlowFuse/website#2603 (comment)

@joepavitt
Copy link
Contributor

First one states that keys will transfer, but the values will not. Now, the new one states that keys will not be overwritten, but that implies the values will?

@joepavitt
Copy link
Contributor

@Steve-Mcl just chasing for a reply to my comment above

@Steve-Mcl
Copy link
Contributor Author

Now, the new one states that keys will not be overwritten, but that implies the values will?

Thats not what i (and the other guys who discussed this on Slack) infer from it ;) but since you did, perhaps a simplification would be better?

Environment variables in the target instance that already have a value will not be overwritten

Clean, to the point.


More explicit?:

Environment variables will be copied to the target instance but any that already have a value will not be overwritten.


Super precise?:

Environment Variables will be copied from the source to the target instance. Any Environment Variables that the target already has will not be overwritten if they contain a value however empty Environment Variables will be updated.

Thoughts?

@joepavitt
Copy link
Contributor

Environment variables in the target instance that already have a value will not be overwritten

This please

reword as per discussion
@Steve-Mcl
Copy link
Contributor Author

Environment variables in the target instance that already have a value will not be overwritten

This please

Done diddly done.

a0e93c4

…ariables-in-the-pipeline-push-to-stage-dialog
…ariables-in-the-pipeline-push-to-stage-dialog
…ariables-in-the-pipeline-push-to-stage-dialog
@Steve-Mcl Steve-Mcl merged commit aea67e9 into main Oct 24, 2024
10 checks passed
@Steve-Mcl Steve-Mcl deleted the 4603-confusing-statement-about-environment-variables-in-the-pipeline-push-to-stage-dialog branch October 24, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing statement about environment variables in the pipeline "push to stage" dialog
4 participants