-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify "Push to stage" dialog env var statement #4604
Clarify "Push to stage" dialog env var statement #4604
Conversation
Feel free to merge after tests pass |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4604 +/- ##
=======================================
Coverage 78.74% 78.74%
=======================================
Files 311 311
Lines 14669 14669
Branches 3354 3354
=======================================
Hits 11551 11551
Misses 3118 3118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @cstns appreciate quick feedback. Hoping to also get the "OK" from @joepavitt and perhaps @sumitshinde-84 too since it arose from confusion in the new pipelines article here: FlowFuse/website#2603 (comment) |
First one states that |
@Steve-Mcl just chasing for a reply to my comment above |
Thats not what i (and the other guys who discussed this on Slack) infer from it ;) but since you did, perhaps a simplification would be better?
Clean, to the point. More explicit?:
Super precise?:
Thoughts? |
This please |
reword as per discussion
Done diddly done. |
…ariables-in-the-pipeline-push-to-stage-dialog
…ariables-in-the-pipeline-push-to-stage-dialog
…ariables-in-the-pipeline-push-to-stage-dialog
closes #4603
Description
Clarify "Push to stage" dialog env var statement
Before:
After:
Related Issue(s)
#4603
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label