4563 replace instance and audit logs dropdowns #4567
Conversation
…instance-and-audit-logs-dropdowns
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4567 +/- ##
=======================================
Coverage 78.72% 78.72%
=======================================
Files 311 311
Lines 14672 14672
Branches 3355 3355
=======================================
Hits 11551 11551
Misses 3121 3121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| 'team.id' () { | ||
| this.loadUsers() | ||
| 'team.id': { | ||
| handler: function (teamId) { if (teamId) this.loadUsers() }, |
There was a problem hiding this comment.
addressed a bug where team members were not loaded when the page loaded, resulting in an empty users list
…instance-and-audit-logs-dropdowns
There was a problem hiding this comment.
Happy to approve @cstns but firstly, I am curious why we are only doing the Envent Type and User but not the Event Scope immediately above?
Should the items on a single page not be done in tandem?
Happy to proceed, but thought to ask in case it was an oversight.
|
It wasn't oversight, It's just the crazy way I managed to split the input's when creating the tasks, Should be fixed by #4561 |
cstns
changed the base branch from
main
to
4562_replace-assetCompare-visibility-selector-and-logs-dropdowns
cstns
changed the base branch from
4562_replace-assetCompare-visibility-selector-and-logs-dropdowns
to
main
|
@cstns are we merging this? |
|
We will not, there's something wrong with the audit log user selector which the e2e tests picked up. Will look at it in more depth after the release |
Description
Related Issue(s)
closes #4563
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel