Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versions info to Project model #4526

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Add versions info to Project model #4526

merged 2 commits into from
Sep 20, 2024

Conversation

knolleary
Copy link
Member

Part of #4522

This captures the versions info returned by the launcher into a new versions property of the Project model.

The versions property stores the version info in the following format:

{
   "node-red": { "current": "4.0.2" }
}

The launcher also reports back node and launcher versions - which get stored as well.

The choice of current is for future consideration of storing the node module information in one place - where there may be a difference between the wanted and the current version. The choice of key names is based on those used by npm outdated output.

This PR includes a migration

We also have #4518 open that contains a migration. Depending which one merges first, the other will need to rename its migration file to ensure the ordering is preserved.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 78.07%. Comparing base (5e468c4) to head (731e442).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
forge/db/models/Project.js 21.05% 15 Missing ⚠️
.../migrations/20240920-01-add-versions-to-project.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4526      +/-   ##
==========================================
- Coverage   78.15%   78.07%   -0.08%     
==========================================
  Files         299      300       +1     
  Lines       14261    14285      +24     
  Branches     3235     3241       +6     
==========================================
+ Hits        11145    11153       +8     
- Misses       3116     3132      +16     
Flag Coverage Δ
backend 78.07% <33.33%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Steve-Mcl
Copy link
Contributor

Any specific merge window for this Nick?

@knolleary

@knolleary
Copy link
Member Author

Good to merge once tests pass

@Steve-Mcl Steve-Mcl merged commit 31e884b into main Sep 20, 2024
13 of 14 checks passed
@Steve-Mcl Steve-Mcl deleted the 4522-capture-nr-version branch September 20, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants