-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user to flow to StorageFlows table, to record who triggered auto snapshot #4518
Draft
hardillb
wants to merge
6
commits into
main
Choose a base branch
from
add-user-to-flows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4fa9ef4
Record who deployed flow that triggered auto snapshot
hardillb c5f823f
fix lint
hardillb 09f8433
Merge branch 'main' into add-user-to-flows
hardillb aac359c
rename migration
hardillb 1a917e7
Merge branch 'add-user-to-flows' of https://github.com/FlowFuse/flowf…
hardillb 2ea8807
Add tests
hardillb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/** | ||
* Add User to StorageFlows table | ||
*/ | ||
const { DataTypes } = require('sequelize') | ||
|
||
module.exports = { | ||
up: async (context) => { | ||
await context.addColumn('StorageFlows', 'UserId', { | ||
type: DataTypes.INTEGER, | ||
allowNull: true, | ||
defaultValue: null, | ||
references: { model: 'Users', key: 'id' }, | ||
// CHECK ME | ||
onDelete: 'SET NULL', | ||
// CHECK ME | ||
onUpdate: 'CASCADE' | ||
}) | ||
}, | ||
down: async (context) => { | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -25,14 +25,20 @@ module.exports = async function (app) { | |||||
|
||||||
app.post('/:projectId/flows', async (request, response) => { | ||||||
const id = request.params.projectId | ||||||
let UserId = null | ||||||
if (request.headers['ff-user']) { | ||||||
UserId = app.db.models.User.decodeHashid(request.headers['ff-user'])[0] | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
} | ||||||
// Check if the project exists first | ||||||
let flow = await app.db.models.StorageFlow.byProject(id) | ||||||
if (flow) { | ||||||
flow.flow = JSON.stringify(request.body) | ||||||
flow.UserId = UserId | ||||||
await flow.save() | ||||||
} else { | ||||||
flow = await app.db.models.StorageFlow.create({ | ||||||
flow: JSON.stringify(request.body), | ||||||
UserId, | ||||||
ProjectId: id | ||||||
}) | ||||||
|
||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy with cascades