-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a directory navigation component #4473
Conversation
…er metadata , remove currentDirectory,
… the breadcrumbs should be ignored due to how the relative path is resolved
…navigation-component
…d-file-asset-service-visibility-selector
…ate after successful visibility update in order to not confuse users
…d-file-asset-service-visibility-selector
Mobile is not yet optimized |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4473 +/- ##
=======================================
Coverage 78.12% 78.13%
=======================================
Files 296 296
Lines 14125 14135 +10
Branches 3189 3192 +3
=======================================
+ Hits 11035 11044 +9
- Misses 3090 3091 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…component' into 4449_add-a-directory-navigation-component
…nto 4461_add-file-asset-service-visibility-selector
…bility-selector' into 4461_add-file-asset-service-visibility-selector
…sibility-selector 4461 add file asset service visibility selector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally, excellent and intuitive. Few minor pieces:
Changes I've made
- Add
gap
between the "copy" button and the file path for better readability.
Copying Folder Paths
I don't believe there is any value in being able to copy the File Path
for a Folder, it also clashes with the row-click which then nests into that folder too. I vote not showing the "copy" button (and functionality) for folder rows.
Inconsistent Highlighting
If you mouseover on the file path for a file, it highlight blue, but isn't clickable, only the "copy" button is. It would be nice to have the text clickable too, which triggers the copy logic.
… click and disable text copy for folders
Making the Update: Just pushed the fix |
Approved subjects to tests passing one final time - all looks good. @cstns please make sure we get a changelog entry and updates in the relevant documentation |
Created FlowFuse/website#2587 for the changelog entry, will tackle both changelog & docs first thing tomorrow |
Description
Added a directory navigation component that resembles the provided mockup
Simplified frontend file navigation as it had too many moving parts, left the breadcrumbs object as the single source of truth
Related Issue(s)
closes #4449
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label